Moved compiled snos import to allowing using snos as a dependency #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
notlesh
approved these changes
Oct 15, 2024
HermanObst
approved these changes
Oct 15, 2024
HermanObst
requested changes
Oct 15, 2024
There was a problem hiding this comment.
@matzayonc plase fix clippy and formatter so the CI can run :)
Otherwise code seems good!
|
Thanks, I'm already using it as a dependency and it works perfectly fine now! |
matzayonc
force-pushed
the
fix/snos-file-dependency
branch
from
0acce89
to
79a6553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: N/A
Type
Description
I moved the include_bytes!() with snos import to tests and binary, because it is not present when used as a dependency.
Breaking changes?