Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing constant MAX_HIGH #410

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Missing constant MAX_HIGH #410

merged 3 commits into from
Oct 18, 2024

Conversation

ftheirs
Copy link
Collaborator

@ftheirs ftheirs commented Oct 16, 2024

Problem: some blocks fail with this error: inner_exc error: Got an exception while executing a hint: Missing constant: MAX_HIGH

Solution: Since this seems to be a bug in cairo-vm, we've implemented a default value for MAX_HIGH and MAX_LOW if they are not found on the constants HashMap.
Related PR: Moonsong-Labs/cairo-vm#47
In order to get the CI in green, the previous PR has to be merged. Current snos project points to the branch, so it's not needed to update Cargo.toml

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@ftheirs ftheirs marked this pull request as ready for review October 17, 2024 20:12
Copy link
Collaborator

@HermanObst HermanObst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HermanObst HermanObst merged commit 8776b73 into main Oct 18, 2024
6 checks passed
@HermanObst HermanObst deleted the ft/fix_max_high branch October 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants