-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset splitter sizes on database unlock #11014
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11014 +/- ##
===========================================
+ Coverage 63.71% 63.78% +0.06%
===========================================
Files 362 362
Lines 38001 38027 +26
===========================================
+ Hits 24211 24252 +41
+ Misses 13790 13775 -15 ☔ View full report in Codecov by Sentry. |
ac96b79
to
0046bc1
Compare
0046bc1
to
b5f5106
Compare
bc67f2e
to
cb39275
Compare
I want to write unit tests for this before I merge |
* Attempt to avoid issue with splitters not being appropriately calculated because the main window isn't sized yet. This can happen if the main window is hidden when the database is loaded and the splitter sizes are not recorded in the config file.
* Prevent group pane from being hidden just by dragging. Introduce new View menu setting to hide the group pane. * Replace the preview panel "close" icon with a "collapse down" icon making the intention clearer. * Better organize the view menu
cb39275
to
e2f16dd
Compare
@phoerious can you take another look? I added a commit that disables collapsing the group view and instead adds a view menu action to explicitly show/hide the group view. The behavior is similar to the preview panel. |
Improve related splitter UX as well:
Testing strategy
Manual testing is pending...
Type of change