chore: upgraded to controller-runtime 0.17.2 and ginkgo v2 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Che Peng <[email protected]>
ccpeng
force-pushed
the
kubebuilder-v3-compliant
branch
from
6b851df
to
6454a44
Compare
Signed-off-by: Chun-Che Peng <[email protected]>
ccpeng
force-pushed
the
kubebuilder-v3-compliant
branch
from
f22d30f
to
7c68b0f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 55.81% 57.10% +1.28%
==========================================
Files 14 14
Lines 1933 1485 -448
==========================================
- Hits 1079 848 -231
+ Misses 734 517 -217
Partials 120 120 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chun-Che Peng <[email protected]>
ccpeng
changed the title
ccpeng
commented
May 29, 2024
| @@ -52,18 +52,6 @@ const ( | |||
| controllerName = "addon-manager-controller" | |||
| ) | |||
|
|
|||
| // Watched resources | |||
| var ( | |||
There was a problem hiding this comment.
resources was unused
kevdowney
reviewed
May 29, 2024
| RunSpecsWithDefaultAndCustomReporters(t, | ||
| "v1alpha1 Suite", | ||
| []Reporter{printer.NewlineReporter{}}) | ||
| RunSpecs(t, "v1alpha1 Suite") |
There was a problem hiding this comment.
Does this automatically print the logs as we expect?
kevdowney
reviewed
May 29, 2024
| RunSpecsWithDefaultAndCustomReporters(t, | ||
| "Controller Suite", | ||
| []Reporter{printer.NewlineReporter{}}) | ||
| RunSpecs(t, "Controller Suite") |
There was a problem hiding this comment.
Same as above, do RunSpecs without further args print logs during test?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #276
note: starting controller-runtime v0.15, fake client status update works differently
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0