fix: address review comments

keikoproj · Nov 6, 2024 · 5ea2e85 · 5ea2e85
1 parent 599436d
commit 5ea2e85
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/docs/syntax.md b/docs/syntax.md
@@ -50,6 +50,7 @@ Below you will find the step syntax next to the name of the method it utilizes.
 - `<GK> [the] deployment <any-characters-except-(")> is running in namespace <any-characters-except-(")>` kdt.KubeClientSet.DeploymentIsRunning
 - `<GK> [the] data in [the] ConfigMap "<any-characters-except-(")>" in namespace "<any-characters-except-(")>" has key "<any-characters-except-(")>" with value "<any-characters-except-(")>"` kdt.KubeClientSet.ConfigMapDataHasKeyAndValue
 - `<GK> [the] persistentvolume <any-characters-except-(")> exists with status (Available|Bound|Released|Failed|Pending)` kdt.KubeClientSet.PersistentVolExists
+- `<GK> [the] persistentvolumeclaim <any-characters-except-(")> exists with status (Available|Bound|Released|Failed|Pending) in namespace <any-characters-except-(")>` kdt.KubeClientSet.PersistentVolClaimExists
 - `<GK> [the] (clusterrole|clusterrolebinding) with name <any-characters-except-(")> should be found` kdt.KubeClientSet.ClusterRbacIsFound
 - `<GK> [the] ingress <non-whitespace-characters> in [the] namespace <non-whitespace-characters> [is] [available] on port <digits> and path <any-characters-except-(")>` kdt.KubeClientSet.IngressAvailable
 - `<GK> [I] send <digits> tps to ingress <non-whitespace-characters> in [the] namespace <non-whitespace-characters> [available] on port <digits> and path <any-characters-except-(")> for <digits> (minutes|seconds) expecting up to <digits> error[s]` kdt.KubeClientSet.SendTrafficToIngress

diff --git a/pkg/kube/structured/structured.go b/pkg/kube/structured/structured.go
@@ -236,11 +236,13 @@ func PersistentVolExists(kubeClientset kubernetes.Interface, name, expectedPhase
 }
 
 func PersistentVolClaimExists(kubeClientset kubernetes.Interface, name, expectedPhase string, namespace string) error {
-	vol, err := GetPersistentVolumeClaim(kubeClientset, name, namespace)
+	vol, err := util.RetryOnError(&util.DefaultRetry, util.IsRetriable, func() (interface{}, error) {
+		return GetPersistentVolumeClaim(kubeClientset, name, namespace)
+	})
 	if err != nil {
 		return err
 	}
-	phase := string(vol.Status.Phase)
+	phase := string(vol.(*corev1.PersistentVolumeClaim).Status.Phase)
 	if phase != expectedPhase {
 		return fmt.Errorf("persistentvolumeclaim had unexpected phase %v, expected phase %v", phase, expectedPhase)
 	}

diff --git a/pkg/kube/structured/structured_test.go b/pkg/kube/structured/structured_test.go
@@ -501,7 +501,7 @@ func TestPersistentVolClaimExists(t *testing.T) {
 				kubeClientset: fake.NewSimpleClientset(getResource(t, persistentVolumeClaimType, persistentvolumeClaimName)),
 				name:          persistentvolumeClaimName,
 				namespace:     "",
-				expectedPhase: "",
+				expectedPhase: "Bound",
 			},
 			wantErr: false,
 		},
@@ -518,7 +518,7 @@ func TestPersistentVolClaimExists(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if err := PersistentVolClaimExists(tt.args.kubeClientset, tt.args.name, tt.args.namespace, tt.args.expectedPhase); (err != nil) != tt.wantErr {
+			if err := PersistentVolClaimExists(tt.args.kubeClientset, tt.args.name, tt.args.expectedPhase, tt.args.namespace); (err != nil) != tt.wantErr {
 				t.Errorf("PersistentVolClaimExists() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})
@@ -885,6 +885,9 @@ func getResourceWithAll(t *testing.T, resourceType, name, namespace, label strin
 				Namespace: namespace,
 				Labels:    labels,
 			},
+			Status: corev1.PersistentVolumeClaimStatus{
+				Phase: corev1.ClaimBound,
+			},
 		}
 	case statefulSetType:
 		return &appsv1.StatefulSet{