-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding step 'pods converge to selector' + fix: CI & syntax #147
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 53.20% 45.80% -7.41%
==========================================
Files 12 19 +7
Lines 1669 1871 +202
==========================================
- Hits 888 857 -31
- Misses 674 900 +226
- Partials 107 114 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PodsInNamespaceWithLabelSelectorConvergeToFieldSelector
replace
package to better handle the replacement of brackets in the syntax generation.CI / make all
intoCI / build-test-coverage
&CI / syntax
for claritygolangci-lint / lint
toCI / golangci-lint
for consistancycodecov.yml