Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding step 'pods converge to selector' + fix: CI & syntax #147

Merged
merged 15 commits into from
Apr 11, 2024

Conversation

garomonegro
Copy link
Collaborator

@garomonegro garomonegro commented Apr 9, 2024

  • adds new step implemented by PodsInNamespaceWithLabelSelectorConvergeToFieldSelector
  • fixes syntax generation broken by the new step
    • adds replace package to better handle the replacement of brackets in the syntax generation.
  • fixes CI broken by codecov
  • splits CI / make all into CI / build-test-coverage & CI / syntax for clarity
  • renames golangci-lint / lint to CI / golangci-lint for consistancy
  • adds codecov.yml

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 75.71429% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 45.80%. Comparing base (72fe744) to head (3309dcb).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/kube/pod/pod.go 64.28% 5 Missing and 5 partials ⚠️
generate/syntax/main.go 0.00% 2 Missing ⚠️
generate/syntax/replace/replace.go 93.93% 1 Missing and 1 partial ⚠️
pkg/kube/kube.go 0.00% 2 Missing ⚠️
kubedog.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   53.20%   45.80%   -7.41%     
==========================================
  Files          12       19       +7     
  Lines        1669     1871     +202     
==========================================
- Hits          888      857      -31     
- Misses        674      900     +226     
- Partials      107      114       +7     
Flag Coverage Δ
unittests 45.80% <75.71%> (-7.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garomonegro garomonegro marked this pull request as ready for review April 10, 2024 23:45
@garomonegro garomonegro requested review from a team as code owners April 10, 2024 23:45
@garomonegro garomonegro changed the title feat: adding step 'pods converge to selector' feat: adding step 'pods converge to selector' + fix: CI & syntax Apr 11, 2024
docs/syntax.md Outdated Show resolved Hide resolved
Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garomonegro garomonegro merged commit 5b5a76b into master Apr 11, 2024
5 of 6 checks passed
@garomonegro garomonegro deleted the cronjob-bdd branch April 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants