build: go 1.21, godog 0.14.1, api, apimachinery & client-go v0.28.12 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 46.02% 46.02%
=======================================
Files 19 19
Lines 1888 1888
=======================================
Hits 869 869
Misses 903 903
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kevdowney
reviewed
Jul 31, 2024
| @@ -6,6 +6,7 @@ pkg/generic/test/generated_* | |||
| pkg/kube/unstructured/test/templates/generated_* | |||
| kubedog | |||
| coverage.txt | |||
| examples/templating/generic/generic | |||
There was a problem hiding this comment.
It's generic/generic path only or should it ignore any generic/* path?
There was a problem hiding this comment.
That is a binary. Its created after building the examples with the build-examples make target
inshbha2
pushed a commit
to inshbha2/kubedog
that referenced
this pull request
Nov 5, 2024
…eikoproj#161) * build: go 1.21, godog 0.14.1, api, apimachinery & client-go v0.28.12 * ci: building examples * ci(examples): check-dirty-repo * test(UT): fixing getIngressWithHostname * test(UT): fixing TestGetInstanceGroupList * refactor: replace 'err == wait.ErrWaitTimeout' with 'wait.Interrupted(err)' * chore: adding missed space Signed-off-by: sbhat14 <[email protected]>
inshbha2
pushed a commit
to inshbha2/kubedog
that referenced
this pull request
Nov 6, 2024
…eikoproj#161) * build: go 1.21, godog 0.14.1, api, apimachinery & client-go v0.28.12 * ci: building examples * ci(examples): check-dirty-repo * test(UT): fixing getIngressWithHostname * test(UT): fixing TestGetInstanceGroupList * refactor: replace 'err == wait.ErrWaitTimeout' with 'wait.Interrupted(err)' * chore: adding missed space Signed-off-by: sbhat14 <[email protected]>
garomonegro
added a commit
that referenced
this pull request
Nov 12, 2024
* build: go 1.21, godog 0.14.1, api, apimachinery & client-go v0.28.12 (#161) * build: go 1.21, godog 0.14.1, api, apimachinery & client-go v0.28.12 * ci: building examples * ci(examples): check-dirty-repo * test(UT): fixing getIngressWithHostname * test(UT): fixing TestGetInstanceGroupList * refactor: replace 'err == wait.ErrWaitTimeout' with 'wait.Interrupted(err)' * chore: adding missed space Signed-off-by: sbhat14 <[email protected]> * feat: add method to check pvc exists Signed-off-by: sbhat14 <[email protected]> * fix: address review comments Signed-off-by: sbhat14 <[email protected]> * fix: retry Signed-off-by: sbhat14 <[email protected]> * remove unnecessary string formatting Signed-off-by: sbhat14 <[email protected]> --------- Signed-off-by: sbhat14 <[email protected]> Co-authored-by: Alfredo Garo <[email protected]> Co-authored-by: sbhat14 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.