use the copied node obj to drain the node #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZihanJiang96
force-pushed
the
drain-node-use-copy
branch
from
f7602e9
to
8bb6043
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 69.74% 69.78% +0.04%
==========================================
Files 12 12
Lines 1312 1314 +2
==========================================
+ Hits 915 917 +2
Misses 325 325
Partials 72 72 ☔ View full report in Codecov by Sentry. |
tekenstam
reviewed
Nov 14, 2023
pkg/service/nodes.go
Outdated
| err = drainNodeUtil(node, int(timeout), kubeClient) | ||
| // create a copy of the node obj, since RunCordonOrUncordon() modifies the node obj | ||
| nodeCopy := node.DeepCopy() | ||
| err = drainNodeUtil(nodeCopy, int(timeout), kubeClient) | ||
| if err == nil { | ||
| log.Info("drain suceeded") |
There was a problem hiding this comment.
Can you also fix the spelling error and change to succeeded?
There was a problem hiding this comment.
Please help to add the node name and instance id in both retry drain and drain succeeded logs.
it will help debugging.
There was a problem hiding this comment.
fixed both. please review again.
ZihanJiang96
force-pushed
the
drain-node-use-copy
branch
from
8bb6043
to
5788885
Compare
tekenstam
approved these changes
Nov 14, 2023
Signed-off-by: Zihan Jiang <[email protected]>
ZihanJiang96
force-pushed
the
drain-node-use-copy
branch
from
5788885
to
6f12728
Compare
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #164