-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a flag to select target types to deregister instance from #214
add a flag to select target types to deregister instance from #214
Conversation
Signed-off-by: Yuxuan Zhu <[email protected]>
Signed-off-by: Yuxuan Zhu <[email protected]>
Signed-off-by: Yuxuan Zhu <[email protected]>
Signed-off-by: Yuxuan Zhu <[email protected]>
Signed-off-by: Yuxuan Zhu <[email protected]>
b2a1b04
to
8494c52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 66.52% 66.72% +0.19%
==========================================
Files 15 15
Lines 1168 1172 +4
==========================================
+ Hits 777 782 +5
+ Misses 319 318 -1
Partials 72 72 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuxuan Zhu <[email protected]>
3f2e1f5
to
a57163e
Compare
Changes
Added a flag
deregister-target-types
which is a comma separated list of target types to deregister instance from. By default the value is"classic-elb,target-group"
. Supported target types areclassic-elb
andtarget-group
.Tests
Manually applied the image in dev cluster.
When
--deregister-target-types=classic-elb,target-group
, life cycle manager scan through all targets that match both target types.When
- --deregister-target-types=classic-elb
, life cycle manager only scan through targets that are classic elb.Then life cycle manager deregisters the instance only from targets found from scanning.