Skip to content

Commit

Permalink
rename variable
Browse files Browse the repository at this point in the history
  • Loading branch information
keith-turner committed Sep 3, 2024
1 parent 6a659d5 commit 227e61e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,9 @@ private void manageMemory() {
}

public void updateMemoryUsageStats(Tablet tablet, long size, long lastCommitTime, long mincSize,
Timer elapsedSinceFirstWrite) {
memUsageReports.add(
new TabletMemoryReport(tablet, lastCommitTime, size, mincSize, elapsedSinceFirstWrite));
Timer firstWriteTimer) {
memUsageReports
.add(new TabletMemoryReport(tablet, lastCommitTime, size, mincSize, firstWriteTimer));
}

public void tabletClosed(KeyExtent extent) {
Expand Down Expand Up @@ -729,6 +729,7 @@ public void updateMemoryUsageStats(Tablet tablet, long size, long mincSize) {
// when a new in memory map is created this method is called with a size of zero so use that
// to reset the first write timer
firstReportedCommitTimer.set(null);
report = true;
} else if (firstReportedCommitTimer.get() == null) {
// this is the first time a non zero size was seen for this in memory map so consider this
// the time of the first write
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ public class TabletMemoryReport implements Cloneable {
private final long lastCommitTime;
private final long memTableSize;
private final long minorCompactingMemTableSize;
private final Timer elapsedSinceFirstWrite;
private final Timer firstWriteTimer;

public TabletMemoryReport(Tablet tablet, long lastCommitTime, long memTableSize,
long minorCompactingMemTableSize, Timer elapsedSinceFirstWrite) {
long minorCompactingMemTableSize, Timer firstWriteTimer) {
this.tablet = tablet;
this.lastCommitTime = lastCommitTime;
this.memTableSize = memTableSize;
this.minorCompactingMemTableSize = minorCompactingMemTableSize;
this.elapsedSinceFirstWrite = elapsedSinceFirstWrite;
this.firstWriteTimer = firstWriteTimer;
}

public KeyExtent getExtent() {
Expand All @@ -54,7 +54,7 @@ public long getLastCommitTime() {
}

public long getElapsedSinceFirstWrite(TimeUnit unit) {
return elapsedSinceFirstWrite == null ? 0 : elapsedSinceFirstWrite.elapsed(unit);
return firstWriteTimer == null ? 0 : firstWriteTimer.elapsed(unit);
}

public long getMemTableSize() {
Expand Down

0 comments on commit 227e61e

Please sign in to comment.