Skip to content

Commit

Permalink
Remove warning banner about breakpoints in Chrome 115 (flutter#6179)
Browse files Browse the repository at this point in the history
  • Loading branch information
elliette authored Aug 14, 2023
1 parent 0cf8afd commit 1df4b6d
Showing 1 changed file with 0 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:vm_service/vm_service.dart';

import '../../shared/analytics/analytics.dart' as ga;
import '../../shared/analytics/constants.dart' as gac;
import '../../shared/banner_messages.dart';
import '../../shared/common_widgets.dart';
import '../../shared/diagnostics/primitives/source_location.dart';
import '../../shared/flex_split_column.dart';
Expand Down Expand Up @@ -127,8 +126,6 @@ class DebuggerScreenBodyState extends State<DebuggerScreenBody>
),
);
});
// TODO(elliette): Remove once Chrome issue is resolved.
_maybeShowBreakpointsWarningBanner();
}

@override
Expand Down Expand Up @@ -224,26 +221,6 @@ class DebuggerScreenBodyState extends State<DebuggerScreenBody>
);
}

void _maybeShowBreakpointsWarningBanner() {
final isWebApp = serviceManager.connectedApp?.isDartWebAppNow ?? false;
final chrome115BreakpointBug =
devToolsExtensionPoints.chrome115BreakpointBug();
if (isWebApp && chrome115BreakpointBug != null) {
bannerMessages.addMessage(
BannerWarning(
key: const Key('Chrome115BreakpointsWarning'),
textSpans: [
TextSpan(
text:
'Setting a breakpoint in Chrome version 115 will crash your app. See $chrome115BreakpointBug',
),
],
screenId: DebuggerScreen.id,
),
);
}
}

void _onNodeSelected(VMServiceObjectNode? node) {
final location = node?.location;
if (location != null) {
Expand Down

0 comments on commit 1df4b6d

Please sign in to comment.