Add an integration test for package:devtools_extensions (flutter#6433)

kenzieschmoll · Sep 21, 2023 · 9838895 · 9838895
1 parent ecd82ce
commit 9838895
Show file tree

Hide file tree

Showing 18 changed files with 18,707 additions and 18,304 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -108,15 +108,15 @@ jobs:
         run: |
           echo "::notice title=To Quickly Fix Goldens:: Run \`devtools_tool fix-goldens --run-id=$WORKFLOW_ID\` on your local branch."
 
-  integration-test:
-    name: integration-test ${{ matrix.bot }} - ${{ matrix.device }} - shard ${{ matrix.shard }}
+  devtools-app-integration-test:
+    name: devtools_app integration-test ${{ matrix.bot }} - ${{ matrix.device }} - shard ${{ matrix.shard }}
     needs: flutter-prep
     runs-on: macos-latest
     strategy:
       fail-fast: false
       matrix:
         # Consider running integration tests in ddc mode, too.
-        bot: [dart2js]
+        bot: [integration_dart2js]
         device: [flutter, flutter-web, dart-cli]
         # Option 1/1 will run all tests for a device in a single shard.
         # Option 1/2 and 2/2 should be enabled to run tests for a device in 2 shards.
@@ -163,6 +163,7 @@ jobs:
           BOT: ${{ matrix.bot }}
           DEVICE: ${{ matrix.device }}
           SHARD: ${{ matrix.shard }}
+          DEVTOOLS_PACKAGE: devtools_app
         run: ./tool/bots.sh
 
       - name: Upload Golden Failure Artifacts
@@ -171,6 +172,31 @@ jobs:
         with:
           name: golden_image_failures.${{ matrix.bot }}
           path: packages/devtools_app/integration_test/**/failures/*.png
+
+  devtools-extensions-integration-test:
+    name: devtools_extensions integration-test ${{ matrix.bot }}
+    needs: flutter-prep
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        # Consider running integration tests in ddc mode, too.
+        bot: [integration_dart2js]
+    steps:
+      - name: git clone
+        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
+      - name: Load Cached Flutter SDK
+        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        with:
+          path: |
+            ./flutter-sdk
+          key: flutter-sdk-${{ runner.os }}-${{ needs.flutter-prep.outputs.latest_flutter_candidate }}
+      - name: tool/bots.sh
+        env:
+          BOT: ${{ matrix.bot }}
+          DEVTOOLS_PACKAGE: devtools_extensions
+        run: ./tool/bots.sh
+
 # TODO(https://github.com/flutter/devtools/issues/1715): add a windows compatible version of tool/bots.sh
 # and run it from this job.
 #  windows-test:

diff --git a/packages/devtools_extensions/CHANGELOG.md b/packages/devtools_extensions/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.0.7-wip
+* Add integration testing.
+* Add `ExtensionManager.unregisterEventHandler` method.
+
 ## 0.0.6
 * Bump `package:devtools_app_shared` dependency to version ^0.0.4.
 

diff --git a/...ols_extensions/example/foo/packages/foo/extension/devtools/build/assets/FontManifest.json b/...ols_extensions/example/foo/packages/foo/extension/devtools/build/assets/FontManifest.json
@@ -1 +1 @@
-[{"family":"packages/devtools_app_shared/Roboto","fonts":[{"weight":100,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Thin.ttf"},{"weight":300,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Light.ttf"},{"weight":400,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Regular.ttf"},{"weight":500,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Medium.ttf"},{"weight":700,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Bold.ttf"},{"weight":900,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Black.ttf"}]},{"family":"packages/devtools_app_shared/RobotoMono","fonts":[{"weight":100,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Thin.ttf"},{"weight":300,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Light.ttf"},{"weight":400,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Regular.ttf"},{"weight":500,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Medium.ttf"},{"weight":700,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Bold.ttf"}]}]
+[{"family":"MaterialIcons","fonts":[{"asset":"fonts/MaterialIcons-Regular.otf"}]},{"family":"packages/devtools_app_shared/Roboto","fonts":[{"weight":100,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Thin.ttf"},{"weight":300,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Light.ttf"},{"weight":400,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Regular.ttf"},{"weight":500,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Medium.ttf"},{"weight":700,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Bold.ttf"},{"weight":900,"asset":"packages/devtools_app_shared/fonts/Roboto/Roboto-Black.ttf"}]},{"family":"packages/devtools_app_shared/RobotoMono","fonts":[{"weight":100,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Thin.ttf"},{"weight":300,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Light.ttf"},{"weight":400,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Regular.ttf"},{"weight":500,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Medium.ttf"},{"weight":700,"asset":"packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Bold.ttf"}]}]
diff --git a/.../example/foo/packages/foo/extension/devtools/build/assets/fonts/MaterialIcons-Regular.otf b/.../example/foo/packages/foo/extension/devtools/build/assets/fonts/MaterialIcons-Regular.otf
diff --git a/...ls_extensions/example/foo/packages/foo/extension/devtools/build/flutter_service_worker.js b/...ls_extensions/example/foo/packages/foo/extension/devtools/build/flutter_service_worker.js
@@ -4,9 +4,9 @@ const TEMP = 'flutter-temp-cache';
 const CACHE_NAME = 'flutter-app-cache';
 
 const RESOURCES = {"version.json": "8028f186743ad08b1d6cd43096c96eea",
-"index.html": "15577b9291c60a2213b1acb9766569cb",
-"/": "15577b9291c60a2213b1acb9766569cb",
-"main.dart.js": "9b0cde0ea96af16049547b8f138d233d",
+"index.html": "15e56b77b9e7b1788ffd6652dbcf3ce9",
+"/": "15e56b77b9e7b1788ffd6652dbcf3ce9",
+"main.dart.js": "ae66b8d79359a6c8fafeb67c9600ad1d",
 "flutter.js": "0b19a3d1d54c58174c41cd35acdd9388",
 "favicon.png": "5dcef449791fa27946b3d35ad8803796",
 "icons/Icon-192.png": "ac9a721a12bbc803b44f645561ecb1e1",
@@ -16,7 +16,7 @@ const RESOURCES = {"version.json": "8028f186743ad08b1d6cd43096c96eea",
 "manifest.json": "b2ccfd393c834a8ff957b519bdabb327",
 "assets/AssetManifest.json": "028594b1cd1c0777d038ea32b0aec44b",
 "assets/NOTICES": "cbfcfd32a8ad8f6f667feec323c838d4",
-"assets/FontManifest.json": "ced8a230a779cd9b12e407c2e0268e66",
+"assets/FontManifest.json": "87d3db7932d6cb734bc450e9ac11b35e",
 "assets/packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Medium.ttf": "7cfbd4284ec01b7ace2f8edb5cddae84",
 "assets/packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Regular.ttf": "b4618f1f7f4cee0ac09873fcc5a966f9",
 "assets/packages/devtools_app_shared/fonts/Roboto_Mono/RobotoMono-Light.ttf": "9d1044ccdbba0efa9a2bfc719a446702",
@@ -30,6 +30,7 @@ const RESOURCES = {"version.json": "8028f186743ad08b1d6cd43096c96eea",
 "assets/packages/devtools_app_shared/fonts/Roboto/Roboto-Black.ttf": "ec4c9962ba54eb91787aa93d361c10a8",
 "assets/shaders/ink_sparkle.frag": "f8b80e740d33eb157090be4e995febdf",
 "assets/AssetManifest.bin": "2c828b91620f80bce3f679a14fa02942",
+"assets/fonts/MaterialIcons-Regular.otf": "e7069dfd19b331be16bed984668fe080",
 "canvaskit/skwasm.js": "5256dd3e40ec9fe1fc9faa51a116bcfd",
 "canvaskit/skwasm.wasm": "4ca73baf420612f1657d5b2be4b7467d",
 "canvaskit/chromium/canvaskit.js": "36d162e8f857ceeacbf01ed75a382f56",

diff --git a/packages/devtools_extensions/example/foo/packages/foo/extension/devtools/build/index.html b/packages/devtools_extensions/example/foo/packages/foo/extension/devtools/build/index.html
@@ -34,7 +34,7 @@
 
   <script>
     // The value below is injected by flutter build, do not touch.
-    const serviceWorkerVersion = "1278586758";
+    const serviceWorkerVersion = "2527657290";
   </script>
   <!-- This script adds the flutter initialization JS code -->
   <script src="flutter.js" defer></script>