Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct imports of tf.keras #2048

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

ianstenbit
Copy link
Contributor

@ianstenbit ianstenbit commented Sep 1, 2023

When referencing tf.keras, we should going forward always import it via TF (because in the future this will reference Keras 3)

This leaves in one reference (in models/object_detection/predict_utils.py) because it's going to be removed in #2012 anyway, and it's a bit hairy to fix I think.

@ianstenbit
Copy link
Contributor Author

/gcbrun

@ianstenbit ianstenbit marked this pull request as ready for review September 1, 2023 21:28
@ianstenbit ianstenbit requested a review from grasskin September 1, 2023 21:28
Copy link
Member

@grasskin grasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🧹 !

@ianstenbit ianstenbit merged commit fba14c2 into keras-team:master Sep 7, 2023
@ianstenbit ianstenbit deleted the keras-api-private branch September 7, 2023 17:12
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* Remove direct imports of keras

* Undo change in predict_utils

* Undo augmentation layer changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants