lava: use new dotted-key syntax for storage settings section #293
Conversation
Update how the name of the storage settings section is defined by following the TOML dotted-key syntax with sub-tables. Signed-off-by: Guillaume Tucker <[email protected]>
gctucker
force-pushed
the
lava-storage-section
branch
from
0f489dd
to
b18c754
Compare
| @@ -29,8 +29,7 @@ def _get_api_helper(api_config_name, api_token): | |||
|
|
|||
| def _get_storage(storage_config_name): | |||
| storage_config = CONFIGS['storage_configs'][storage_config_name] | |||
| section = SETTINGS[(':'.join(('storage', storage_config_name)))] | |||
| storage_cred = section['storage_cred'] | |||
| storage_cred = SETTINGS['storage'][storage_config_name]['storage_cred'] | |||
There was a problem hiding this comment.
Can we use parse_opts instead to read the settings from TOML like other services?
There was a problem hiding this comment.
No because this is not a service like the other ones, it's a Flask application. There might be things we can do to try to make it look like a service but I made the design decision to rely directly on the YAML config and TOML settings as it seemed like the best choice in this case.
There was a problem hiding this comment.
Yes, I am aware it's a Flask app but I was wondering if we could use kernelci package somehow to read settings. But it seems not. Looks fine otherwise.
There was a problem hiding this comment.
Yeah it's just not very practical to run a Flask service which already has its own "main" function or WSGI connector as a kernelci-core command line tool. Also it's very straightforward to just read the settings and YAML config, I think a real improvement would be to help separate that logic from the helpers to run command line tools in kernelci-core. But that's really not a blocking issue at the moment, probably something to revisit once the old tools have been completely deprecated.
Update how the name of the storage settings section is defined by following the TOML dotted-key syntax with sub-tables.