Enable suspend and hibernation test #743
Conversation
crazoes
requested review from
padovan,
nuclearcat,
pawiecz,
a-wai and
laura-nao
config/pipeline.yaml
Outdated
| collections: cpufreq | ||
| job_timeout: 10 | ||
| env: 'KSELFTEST_MAIN_SH_ARGS="-t suspend_rtc"' | ||
| kcidb_test_suite: kselftest.cpufreq |
There was a problem hiding this comment.
I'm not sure if we need to define a different kcidb_test_suite here, as this is the same cpufreq kselftest but run with different parameters. @JenySadadia is there an existing convention for this? Users need a way to differentiate between the same test executed with different parameters once the results land in KCIDB.
(This goes back to the discussion raised here)
There was a problem hiding this comment.
I don't think KCIDB has such conventions. Maybe we can use kselftest.cpufreq.suspend and kselftest.cpufreq.hibernate.
CC @spbnick
There was a problem hiding this comment.
Sounds good to me, thanks @JenySadadia ! About the parameters passed to this test, is there any field we can add or re-use to encode this information? besides being useful for filtering results, it's also good information for manually reproducing the issues.
There was a problem hiding this comment.
One way is to store that information in node data field and later on assign that to misc field for KCIDB submission.
|
@laura-nao I just wanted to first see if this approach is correct so thought of only adding the test definition. But I can make changes in my v2 as per the reviews |
crazoes
force-pushed
the
suspend-resume-test
branch
from
13b271c
to
d9b2cba
Compare
crazoes
force-pushed
the
suspend-resume-test
branch
from
d9b2cba
to
b967cca
Compare
pawiecz
removed
the
staging-skip
|
There are still errors on the kci-core side, but this PR is working as expected: multiples instances of |
crazoes
force-pushed
the
suspend-resume-test
branch
from
b967cca
to
5045931
Compare
|
Looks good, can you please invert the entries in pipeline.yaml? |
Signed-off-by: Shreeya Patel <[email protected]>
crazoes
force-pushed
the
suspend-resume-test
branch
from
5045931
to
31f85be
Compare
|
If everything looks good then can we merged this now @nuclearcat @a-wai ? |
| <<: *kselftest-params | ||
| collections: cpufreq | ||
| env: 'KSELFTEST_MAIN_SH_ARGS="-t hibernate_rtc"' | ||
| rules: |
There was a problem hiding this comment.
Maybe we want to run this test on all the trees and not just kernelci. I may not have enough context for this. So what do you think?
|
Did we got results of tests on dashboard or in viewer? |
|
@nuclearcat yes we did get them but lots of tests are failing. https://lava.collabora.dev/scheduler/alljobs?length=25&search=suspend#table It's not really the problem related to the tests or environment but mostly related to the kernel I think. |
|
Thanks! I think soon we will start looking into such problems more. |
Enable suspend and hibernation test. This patch depends on the #743