fix(send_kcidb): Do not crash if optional field is missing #869
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
reviewed
Nov 5, 2024
src/send_kcidb.py
Outdated
| 'git_repository_branch_tip': | ||
| checkout_node['data']['kernel_revision']['tip_of_branch'], | ||
| checkout_node['data']['kernel_revision'].get('tip_of_branch', False), |
There was a problem hiding this comment.
We can keep it None instead of False if the flag is not set.
JenySadadia
reviewed
Nov 5, 2024
| @@ -600,7 +600,8 @@ async def checkout(data: ManualCheckout, request: Request, | |||
| "tree": treename, | |||
| "branch": branch, | |||
| "commit": commit, | |||
| "url": treeurl | |||
| "url": treeurl, | |||
| "tip_of_branch": False | |||
There was a problem hiding this comment.
Custom checkout can also have a commit from the tip of the branch. Why is it set False?
There was a problem hiding this comment.
We cannot trust user to indicate if it is TOT, but to test it separately on our side will need additional logic to implement (or fix existing one).
We might check it later, as it is not critical right now, custom checkout events should not be sent to kcidb anyway (yet).
Some fields might be not present, as they are optional in model. Also add this field in custom checkout, even it is not mandatory, it is better to have it for consistency. Signed-off-by: Denys Fedoryshchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields might be not present, as they are optional in model. Also add this field in custom checkout, even it is not mandatory, it is better to have it for consistency.