Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #612 - a bug while parsing vcalendar parameters. #613

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Fixes #612 - a bug while parsing vcalendar parameters. #613

merged 1 commit into from
Apr 13, 2024

Conversation

br0xpl
Copy link

@br0xpl br0xpl commented Aug 17, 2023

Fixes #612

@br0xpl br0xpl changed the title Fixes #612 - a bug while parsing vcard parameters. Fixes #612 - a bug while parsing vcalendar parameters. Aug 18, 2023
@br0xpl
Copy link
Author

br0xpl commented Sep 6, 2023

@kewisch can you have a look?

@titanism titanism mentioned this pull request Feb 16, 2024
Closed
@kewisch
Copy link
Owner

kewisch commented Mar 25, 2024

Hey, sorry for the long darkness. This sounds reasonable. @br0xpl I know it has been a while, but would you be willing to add a test case for this?

@kewisch kewisch added the needinfo More information has been requested label Mar 25, 2024
@kewisch kewisch mentioned this pull request Mar 25, 2024
Closed
@kewisch kewisch force-pushed the bugfix/empty-parameter-name-fix branch from d983bac to 9971651 Compare April 13, 2024 21:14
@kewisch kewisch merged commit 9e96f20 into kewisch:main Apr 13, 2024
7 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8676303651

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 98.025%
Totals Coverage Status
Change from base Build 8643210213: 0.001%
Covered Lines: 9289
Relevant Lines: 9460
💛 - Coveralls

@github-actions github-actions bot removed the needinfo More information has been requested label Apr 13, 2024
@galopeian1 galopeian1 mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewisch kewisch kewisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in parameter parsing function "Empty parameter name"
3 participants
@br0xpl @kewisch @coveralls