Simplify lazy initialisation of TimezoneService. #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darktrojan
force-pushed
the
timezone-service-startup
branch
from
d440f1a
to
ce38022
Compare
It appears the current way of bootstrapping the core zones exists because TimezoneService's position among the modules means we can't call reset immediately. Something seem to not work right and leads to Time.epochTime being in the floating time zone instead of UTC. At least when run in Thunderbird, I'm not sure if it always happens. My patch just creates the zones on first use.
darktrojan
force-pushed
the
timezone-service-startup
branch
from
ce38022
to
ced32d8
Compare
|
Oops, I failed at git. |
Pull Request Test Coverage Report for Build 8547113242Details
💛 - Coveralls |
leftmostcat
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the current way of bootstrapping the core zones exists because TimezoneService's position among the modules means we can't call reset immediately.
Something seem to not work right and leads to Time.epochTime being in the floating time zone instead of UTC. At least when run in Thunderbird, I'm not sure if it always happens. My patch just creates the zones on first use.