Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Invalid Characters in Path #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle Invalid Characters in Path #35

wants to merge 2 commits into from
+31 −2

Conversation

elgertam
Copy link
Member

  • Added exception when a character in the path is not valid on Synapse
  • Added test verifying that invalid paths throw exceptions

@elgertam
Handle Invalid Characters in Path
3bddb26 
* Added exception when a character in the path is not valid on Synapse
* Added test verifying that invalid paths throw exceptions
@elgertam elgertam requested a review from pcstout June 18, 2019 21:41
@elgertam elgertam mentioned this pull request Jun 18, 2019
Open
@elgertam elgertam requested a review from hafen June 18, 2019 21:47
pcstout
pcstout requested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@pcstout pcstout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can catch the filename errors (on .store()) and pretty them up that way we don't have to keep a list of valid/invalid chars.

src/kitools/data_adapters/synapse/synapse_adapter.py
@@ -226,6 +229,17 @@ def _data_push(self, ki_project_resource, syn_parent):
sys_path = SysPath(ki_project_resource.abs_path, rel_start=kiproject.local_path)
syn_entity = None

# check for valid characters in string
for rel_part in sys_path.rel_parts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be a method so it can be called on line #219 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcstout pcstout pcstout requested changes

@hafen hafen Awaiting requested review from hafen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elgertam @pcstout