Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following my work on kivikakk/libpcre.zig#18, I attempted to port koino to the package manager for my personal project, https://github.com/lun-4/obsidian2web/tree/zig012
this would be a large change to how koino is distributed as there wouldn't be a need for vendoring the dependencies anymore. dependencies would need respective PRs to port them (which this PR is dependent upon). because of all of this, the PR is unfinished (README was not updated, build.zig.zon refers to my forks of the libraries, etc), and I would be asking for your opinion on such (including dismissing the port altogether)
this also adds a fix to the parser because
@memcpy
will safety check on the length of the slices and safety-panic if the lengths differ (I looked at the two other@memcpy
users and they seem fine), since the parser explicitly wants to add a newline to the end of the input, it would always panic (bug found by doing this porting work. if the zigpkg port is dismissed, I'll submit another PR to fix that specifically lol)dependency PRs (should be merged first):
TODO (if this is accepted):
make spec
functionality