Disable random article in settings view #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
A more proper fix seems to be the following:
- change the type of the parameter of
KiwixApp::disableItemsOnLibraryPage(bool libraryDisplayed)andTabBar::libraryPageDisplayed(bool displayed)fromboolto a new enum type which tells the kind of the current tab (content, library, settings). Inside that function enable only actions that make sense for the current tab kind. - Naturally after that change
KiwixApp::disableItemsOnLibraryPage()andTabBar::libraryPageDisplayed()have to be renamed.
|
Agree with @veloman-yunkan, those functions have been created when there was no setting page. Now we have more than 2 kinds of tab, we should create more generic functions to handle "action configuration" when we change tabs. |
juuz0
force-pushed
the
settingsViewRandomIconGrey
branch
from
29225ac
to
ce1534b
Compare
kiwix-desktop didn't acknowledge the different types of tabs available earlier. These enums provide a way to handle and customize the state of app's different elements based on tab content.
juuz0
force-pushed
the
settingsViewRandomIconGrey
branch
from
ce1534b
to
bf4a0ed
Compare
|
@juuz0 Ready for a new review? |
|
@kelson42 yes |
veloman-yunkan
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #954