Slice len is always non-negative (#261)

klauspost · Nov 28, 2023 · 674f18b · 674f18b
1 parent 81a7aae
commit 674f18b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/leopard.go b/leopard.go
@@ -303,7 +303,7 @@ func (r *leopardFF16) Split(data []byte) ([][]byte, error) {
 			// Copy partial shards
 			copyFrom := data[perShard*fullShards : dataLen]
 			for i := range padding {
-				if len(copyFrom) <= 0 {
+				if len(copyFrom) == 0 {
 					break
 				}
 				copyFrom = copyFrom[copy(padding[i], copyFrom):]

diff --git a/leopard8.go b/leopard8.go
@@ -344,7 +344,7 @@ func (r *leopardFF8) Split(data []byte) ([][]byte, error) {
 			// Copy partial shards
 			copyFrom := data[perShard*fullShards : dataLen]
 			for i := range padding {
-				if len(copyFrom) <= 0 {
+				if len(copyFrom) == 0 {
 					break
 				}
 				copyFrom = copyFrom[copy(padding[i], copyFrom):]

diff --git a/matrix.go b/matrix.go
@@ -67,11 +67,11 @@ var errColSizeMismatch = errors.New("column size is not the same for all rows")
 
 func (m matrix) Check() error {
 	rows := len(m)
-	if rows <= 0 {
+	if rows == 0 {
 		return errInvalidRowSize
 	}
 	cols := len(m[0])
-	if cols <= 0 {
+	if cols == 0 {
 		return errInvalidColSize
 	}
 

diff --git a/reedsolomon.go b/reedsolomon.go
@@ -1633,7 +1633,7 @@ func (r *reedSolomon) Split(data []byte) ([][]byte, error) {
 			// Copy partial shards
 			copyFrom := data[perShard*fullShards : dataLen]
 			for i := range padding {
-				if len(copyFrom) <= 0 {
+				if len(copyFrom) == 0 {
 					break
 				}
 				copyFrom = copyFrom[copy(padding[i], copyFrom):]