Skip to content

Commit

Permalink
fix: tallow not dropping
Browse files Browse the repository at this point in the history
The knife tag change was not reflected in the GLMs, causing the condition to never be met

Closes #1207
  • Loading branch information
klikli-dev committed Sep 12, 2024
1 parent 817de6d commit 986741c
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"predicate": {
"equipment": {
"mainhand": {
"items": "#occultism:tools/knives"
"items": "#occultism:tools/knife"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ private AddItemModifier tallow(String entityType, int count) {
LootItemEntityPropertyCondition
.hasProperties(LootContext.EntityTarget.ATTACKER,
EntityPredicate.Builder.entity()
.equipment(this.mainHand(ItemPredicate.Builder.item().of(OccultismTags.makeItemTag(ResourceLocation.fromNamespaceAndPath(Occultism.MODID, "tools/knives")))))).build(),
.equipment(this.mainHand(ItemPredicate.Builder.item().of(
OccultismTags.Items.TOOLS_KNIFE)))).build(),
LootItemEntityPropertyCondition
.hasProperties(LootContext.EntityTarget.THIS, EntityPredicate.Builder.entity().of(OccultismTags.makeEntityTypeTag(ResourceLocation.fromNamespaceAndPath("c", entityType)))).build()
}, OccultismItems.TALLOW.get(), count);
Expand Down

0 comments on commit 986741c

Please sign in to comment.