Refactorings #18
Open
Refactorings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created a module that will act as a namespace for all pomodoro related functionality
added plan for next refactorings in TODOs
fixed centerY bug in GarmodoroView all TODOs finished
cached tickStrength and tickDuration to reduce battery strain
bugfix: variable height should be dc.getHeight()
- moved properties.mk to properties.mk.example - added properties.mk to .gitignore - added section in README.md Rationale: a new developer will have to change properties.mk . So an example file (properties.mk.example) is helpful, but the actual properties.mk file should not be checked into version control.
|
Thank you for creating this PR, @thomas-gruen. I appreciate it - I'll try to have a look through your improvements this weekend and see what can be incorporated into the vanilla version. It might also give me a nudge to go try to refresh some code, so thank you! I'm glad you found it useful for a base for your own version - open-source FTW! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Igor,
as requested in #17 (comment) :-)
Here are my refactorings. I hope you'll find them useful. A word of caution: I have only 'tested' the program directly on my watch, since I couldn't get the simulator to run. So a thorough test is definitely advised.
The refactorings contained in this pull request were a prerequisite for my alterations of the program (see https://github.com/thomas-gruen/garmodoro/issues?q= ). I suspect, you won't incorporate these into your code, since they modify the programs behavior. However, if you like to, feel free to pull or cherry pick from my repo.
Last but not least, I want to thank you for writing the program in the first place and for making it available for free so graciously. It was a lot easier to modify this program than to start from scratch.
Best regards,
Tom