Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example, document requirements to run example #6

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

philippkeller
Copy link

Hi @klokan
Thanks for providing this repo. It's so hard to get documentation how to get flask to work with firebase.
Still, I had some difficulty getting your example to work, I figured all out and would like to contribute my changes to your README.md file.

@philippkeller
Copy link
Author

I also created a blog post covering this python module here

@keosak
Copy link
Member

keosak commented Jun 21, 2022

Hello @philippkeller,

This repository is pretty much dead. I suggest you make your own fork if you want to develop it. We won't be making any more changes.

@klokan
Copy link
Member

klokan commented Jun 21, 2022

I would love to merge this PR @keosak - is there any danger in doing so?

@philippkeller did a great job here. (greetings to Zurich)

@philippkeller
Copy link
Author

@klokan yay, greetings back to Switzerland 😄

@keosak I would be ok with forking it, if you don't want to maintain. The code looks very strong (a bit above my python level). What I would do with it is to post it to PyPi, update the versions and add one or two more social login providers. Apart from these things the code is running flawlessly. Really nice project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants