Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external transactional endpoint (#1108) #1754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Facecube
Copy link

Hello @knadh,
I am tagging you because you were also involved in the linked issue.

I decided to create a proposal implementation that allows external mails to be sent.
I implemented it as a separate endpoint in order not to interfere with the existing transactional endpoint.
I tested it locally and it seems to work for me.

Prior to this PR I have not written a single line of go, so please go easy on me :).
Looking forward to your feedback and I am happy to make changes, as I really would like to see this feature added to listmonk.

(cherry picked from commit e0473db7861b63d328be506542c340f2e95b6a03)
@Facecube Facecube closed this Mar 25, 2024
@Facecube Facecube reopened this Mar 25, 2024
@knadh
Copy link
Owner

knadh commented Mar 26, 2024

Hi @Facecube. I missed reviewing this last month in the middle of the v3.0.0 release I think. Will look into this sometime in the coming weeks.

@knadh knadh self-assigned this Mar 26, 2024
@knadh knadh added the enhancement New feature or request label Mar 26, 2024
@ugd
Copy link

ugd commented Apr 3, 2024

@knadh, I forked the @Facecube solution, merged with the current release, set it up in a Docker container, and successfully deployed it in production; it has already sent around 60 emails. A useful enhancement would be to add a page for viewing the logs of sent emails.

@Facecube
Copy link
Author

Facecube commented Apr 4, 2024

@ugd there is a logs page in the settings submenu.
But I assume you mean that you want some sort of list view of emails sent, where you can maybe even see the message body, etc.
But cool to see that my changes are actually usable 😆

@ttphi88
Copy link

ttphi88 commented Aug 12, 2024

Hi @knadh
Do you mind reviewing this PR (as the author said he did not have experience with Go) and releasing this feature?
Thank you very much.

@knadh
Copy link
Owner

knadh commented Aug 12, 2024

Hi @ttphi88. It's on my list to review and address after the upcoming v4.0.0 release, which involves serious, significant changes.

@ugd
Copy link

ugd commented Oct 28, 2024

Any updates for v4?

@waza-ari
Copy link

Based on the most recent commits and the RCs that have been published, I’d say it’s close. If I understood it correctly, it involves quite significant changes including authentication and permissions, so it takes a bit longer to get everything right. I’m just another user though, so keep that in the back of your head reading my comment

@ugd
Copy link

ugd commented Oct 29, 2024

Based on the most recent commits and the RCs that have been published, I’d say it’s close. If I understood it correctly, it involves quite significant changes including authentication and permissions, so it takes a bit longer to get everything right. I’m just another user though, so keep that in the back of your head reading my comment

far as i understood, the significant changes are for the v4 release in terms of features, and that moment was inappropriate to concentrate in another new feature 🤔 and maybe this feature will be added after the changes that was in progress will be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants