-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external transactional endpoint (#1108) #1754
base: master
Are you sure you want to change the base?
Conversation
(cherry picked from commit e0473db7861b63d328be506542c340f2e95b6a03)
Hi @Facecube. I missed reviewing this last month in the middle of the v3.0.0 release I think. Will look into this sometime in the coming weeks. |
@ugd there is a logs page in the settings submenu. |
Hi @knadh |
Hi @ttphi88. It's on my list to review and address after the upcoming v4.0.0 release, which involves serious, significant changes. |
Any updates for v4? |
Based on the most recent commits and the RCs that have been published, I’d say it’s close. If I understood it correctly, it involves quite significant changes including authentication and permissions, so it takes a bit longer to get everything right. I’m just another user though, so keep that in the back of your head reading my comment |
far as i understood, the significant changes are for the v4 release in terms of features, and that moment was inappropriate to concentrate in another new feature 🤔 and maybe this feature will be added after the changes that was in progress will be done |
Hello @knadh,
I am tagging you because you were also involved in the linked issue.
I decided to create a proposal implementation that allows external mails to be sent.
I implemented it as a separate endpoint in order not to interfere with the existing transactional endpoint.
I tested it locally and it seems to work for me.
Prior to this PR I have not written a single line of go, so please go easy on me :).
Looking forward to your feedback and I am happy to make changes, as I really would like to see this feature added to listmonk.