Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] Prober targets service instead of pods directly #2180

Conversation

aliok
Copy link
Member

@aliok aliok commented May 11, 2022

Manual cherry pick of #2159

Receiver's prober targets services instead of pods directly to allow components to be part of an Istio mesh

@knative-prow knative-prow bot added area/control-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/data-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2022
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@knative-prow
Copy link

knative-prow bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi changed the title Prober targets service instead of pods directly [release-1.2] Prober targets service instead of pods directly May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-1.2@a1d964e). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.2    #2180   +/-   ##
==============================================
  Coverage               ?   69.37%           
  Complexity             ?      618           
==============================================
  Files                  ?      131           
  Lines                  ?     5518           
  Branches               ?      180           
==============================================
  Hits                   ?     3828           
  Misses                 ?     1383           
  Partials               ?      307           
Flag Coverage Δ
java-unittests 81.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d964e...1120ae7. Read the comment docs.

@aliok
Copy link
Member Author

aliok commented May 11, 2022

/test unit-tests_eventing-kafka-broker_release-1.2

(https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-shade-plugin/3.2.1/maven-shade-plugin-3.2.1.pom: Connection reset -> [Help 1]

@pierDipi
Copy link
Member

/test channel-reconciler-tests-ssl_eventing-kafka-broker_release-1.2

@aliok
Copy link
Member Author

aliok commented May 11, 2022

/test channel-reconciler-tests-ssl_eventing-kafka-broker_release-1.2

Doesn't look good :(

helpers.go:109: Failed to patch the ChannelImpl {error 26 0  Internal error occurred: failed calling webhook "validation.webhook.kafka.eventing.knative.dev": failed to call webhook: Post "[https://kafka-webhook-eventing.knative-eventing.svc:443/resource-validation?timeout=2s](https://kafka-webhook-eventing.knative-eventing.svc/resource-validation?timeout=2s)": EOF}

@pierDipi
Copy link
Member

See knative/pkg#1509

@aliok
Copy link
Member Author

aliok commented May 11, 2022

/test channel-reconciler-tests-ssl_eventing-kafka-broker_release-1.2

ERROR: timeout waiting for pods to come up
strimzi-cluster-operator-76ff9bcc-2hzdj   0/1   Pending   0     5m59s

@knative-prow knative-prow bot merged commit e4feb86 into knative-extensions:release-1.2 May 11, 2022
@aliok aliok deleted the 2022-05-11-upstreamv12-backport-2159 branch May 11, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants