Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[main] Upgrade to latest dependencies #1456

Closed
wants to merge 1 commit into from
Closed

[main] Upgrade to latest dependencies #1456

wants to merge 1 commit into from

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative-extensions/eventing-writers
/assign knative-extensions/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 11, 2024

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-extensions/eventing-writers.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cron -knative-prow-robot

/cc knative-extensions/eventing-writers
/assign knative-extensions/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign lberk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 11, 2024
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 4 times, most recently from 9f5bd9d to 601e951 Compare January 15, 2024 13:27
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2024
matzew
matzew reviewed Jan 16, 2024
View reviewed changes
vendor/knative.dev/eventing/pkg/kncloudevents/event_dispatcher.go
}

func NewDispatcher(oidcTokenProvider *auth.OIDCTokenProvider) *Dispatcher {
func NewDispatcher(clientConfig eventingtls.ClientConfig, oidcTokenProvider *auth.OIDCTokenProvider) *Dispatcher {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, introduced by https://github.com/knative/eventing/pull/7532/files

and causing trouble on the pkg/source/adapter/adapter.go file

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 3 times, most recently from 44d51b6 to 0c0da84 Compare January 17, 2024 13:24
@knative-automation
upgrade to latest dependencies
f2570e8 
bumping knative.dev/reconciler-test 3c6c7d6...50276df:
  > 50276df upgrade to latest dependencies (# 654)
  > 4357f51 upgrade to latest dependencies (# 649)
  > eaf0b82 Update community files (# 653)
  > 71a6b2b Remove kubectl dependency in hack/update-cert-manager.sh (# 652)
  > f3503f8 Update community files (# 651)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 18, 2024

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka_main f2570e8 link true /test unit-tests
build-tests_eventing-kafka_main f2570e8 link true /test build-tests
integration-test-mt-source_eventing-kafka_main f2570e8 link false /test integration-test-mt-source

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Contributor

creydr commented Jan 19, 2024

Closing in favor of #1458

@creydr creydr closed this Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew left review comments

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-automation @creydr @matzew