Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Redis example #1

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Proposal: Redis example #1

wants to merge 1 commit into from

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Apr 14, 2022

Changes

  • 🎁 After building like 5 functions using Redis as the data store, I think that there is a value in providing an example here to help users quickly bootstrap a project with all the dependencies. I've tried to maintain the "echo" idea.. for this case, getting the request body, writing it with an echo in a Redis Key, and then reading it and return it back to the response body.

The big problem that I am facing is that testing complicates the example code a lot. So I am open to suggestions on how to simplify that side of the example.

/kind enhancement

@knative-prow
Copy link

knative-prow bot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: salaboy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@salaboy salaboy marked this pull request as draft April 14, 2022 08:41
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2022
@lance
Copy link
Contributor

lance commented Sep 2, 2022

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants