Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seccompProfile to controller security context #530

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Sep 13, 2023

Changes

/kind

Fixes #

Release Note

Controller and webhooks now have a seccompProfile.type set to RuntimeDefault

Docs


@knative-prow
Copy link

knative-prow bot commented Sep 13, 2023

@KauzClay: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2023
@knative-prow knative-prow bot requested review from krsna-m and nak3 September 13, 2023 16:39
@@ -80,3 +80,5 @@ spec:
capabilities:
drop:
- all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're here can you change this to ALL

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #530 (6a3e4bc) into main (b062d61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   72.76%   72.76%           
=======================================
  Files           9        9           
  Lines         683      683           
=======================================
  Hits          497      497           
  Misses        157      157           
  Partials       29       29           

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@dprotaso
Copy link
Contributor

/retest

@dprotaso
Copy link
Contributor

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit ce4e3e4 into knative-extensions:main Sep 13, 2023
26 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #531

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants