Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang and kind version #541

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Sep 18, 2023

Changes

  • Bumps golang to version 1.21
  • Bumps kind version range from 1.26-1.28
  • Bump k8s.io golang deps to latest 1.26 version

Fixes #538

Depends on chainguard-dev/actions#321

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #541 (003d95d) into main (b19edf4) will increase coverage by 0.29%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   72.47%   72.76%   +0.29%     
==========================================
  Files           9        9              
  Lines         683      683              
==========================================
+ Hits          495      497       +2     
+ Misses        159      157       -2     
  Partials       29       29              
Files Changed Coverage Δ
...kg/reconciler/ingress/resources/reference_grant.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2023
@dprotaso
Copy link
Contributor

/retest
/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@ReToCode
Copy link
Member Author

/retest

@nak3
Copy link
Contributor

nak3 commented Sep 19, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Contributor

nak3 commented Sep 19, 2023

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Sep 19, 2023

@nak3: nak3 unauthorized: /override is restricted to Repo administrators.

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member Author

@dprotaso mind helping out here?

@dprotaso
Copy link
Contributor

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Sep 19, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit d348f30 into knative-extensions:main Sep 19, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Kind and Go in our GitHub Actions
4 participants