Bump to contour 1.26 and use gateway-provisioner

[ReToCode]

Changes

• Bump to contour 1.26
• Drop installation using contour-operator
• Use gateway-provisioner to deploy gateways
• Enable tests that now work: websocket,websocket/split,host-rewrite

/kind enhancement

Fixes #495
Fixes #536

Release Note

net-gateway-api now tests with contour version 1.26 which supports websockets and host-rewrites

[ReToCode]

@dprotaso @nak3 how was this used? Seems like the gateway below just used port 80?

Not sure if we can define this using the gateway-provisioner. If this is needed, we probably need to use helm to have more configuration flags.

[ReToCode]

@KauzClay

[nak3]

IIRC, the 8081 port is used for prober. The current implementation lists endpoint IP which is 8081, and probe against it.

[ReToCode]

Hm, is this still needed? Tests seem to pass without it.

[codecov]

Codecov Report

Merging #555 (a6a2ef4) into main (df07871) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head a6a2ef4 differs from pull request most recent head b237fba. Consider uploading reports for the commit b237fba to get more accurate results

@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files           9        9           
  Lines         691      691           
=======================================
  Hits          505      505           
  Misses        157      157           
  Partials       29       29           

[ReToCode]

message: 'service "ingress-conformance-host-rewrite-ragyzvdm" is invalid: serving-tests/ingress-conformance-host-rewrite-ragyzvdm
is an ExternalName service, these are not currently enabled. See the config.enableExternalNameService
config file setting, service "ingress-conformance-host-rewrite-ragyzvdm" is
invalid: serving-tests/ingress-conformance-host-rewrite-ragyzvdm is an ExternalName
service, these are not currently enabled. See the config.enableExternalNameService
config file setting'

[ReToCode]

I realised that the websocket tests now also work, so also enabling them.

/assign @dprotaso
/assign @nak3
/assign @KauzClay

[nak3]

Deploying the changed manifest seems deploy envoy-knative-local-gateway svc with LoadBalancer not ClusterIP. Is that alright for internal envoy?

$ kubectl get svc -n contour-internal 
NAME                            TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)        AGE
contour-knative-local-gateway   ClusterIP      10.96.50.182    <none>        8001/TCP       19m
envoy-knative-local-gateway     LoadBalancer   10.96.204.218   <pending>     80:30715/TCP   19m

[ReToCode]

Good point, seems to be the default. I added configuration for ClusterIP.

[ReToCode]

/retest

[ReToCode]

/retest

[ReToCode]

/retest

[nak3]

LGTM
@dprotaso @KauzClay will you or VMware team take a look?

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ReToCode,dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment