Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway api crds file to release #571

Merged

Conversation

gabo1208
Copy link
Contributor

Changes

  • 🧹 Add gateway api crds file to release

/kind cleanup

Fixes #539

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 17, 2023
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #571 (42f9e28) into main (4089d16) will not change coverage.
The diff coverage is n/a.

❗ Current head 42f9e28 differs from pull request most recent head f95245d. Consider uploading reports for the commit f95245d to get more accurate results

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files           9        9           
  Lines         691      691           
=======================================
  Hits          505      505           
  Misses        157      157           
  Partials       29       29           

@nak3
Copy link
Contributor

nak3 commented Oct 18, 2023

@gabo1208 Thank you! Could you please rebase this?
Also, once this merged, we need to change https://github.com/knative-extensions/knobots/blob/9a95f1f863feff2231e07a3912a37c4e0210c506/.github/workflows/update-nightlies.yaml#L87 (you might already know about it, though.)

@gabo1208
Copy link
Contributor Author

Didn't knew that! I'm still navigating the whole Serving experience 😄 ! Thank you @nak3

PR done here: knative-extensions/knobots#344

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 18, 2023

/lgtm

Thank you!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@nak3 nak3 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@gabo1208
Copy link
Contributor Author

/retest

@nak3
Copy link
Contributor

nak3 commented Oct 18, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0e28e43 into knative-extensions:main Oct 18, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net-gateway-api shouldn't re-release Gateway API CRDs
2 participants