Wait for deploy/gateway-api-admission-server to make sure webhook is ready #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
kind/cleanup
knative-prow
bot
added
the
size/XS
nak3
added
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 73.08% 73.08%
=======================================
Files 9 9
Lines 691 691
=======================================
Hits 505 505
Misses 157 157
Partials 29 29 |
dprotaso
reviewed
Oct 19, 2023
knative-prow
bot
added
the
size/XS
nak3
removed
the
do-not-merge/hold
gabo1208
approved these changes
Oct 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabo1208, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this patch adds to wait
deploy/gateway-api-admission-serveruntil it becomes Ready.Ideally, we want to verify
validatingwebhookconfigurations.admissionregistration.k8s.iobut it does not have the status so we wait for deployment (pod) becomes Ready./kind cleanup
Release Note
Fix #570