Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gateway-api tests to v1.1 #732

Merged
merged 1 commit into from
May 22, 2024
Merged

bump gateway-api tests to v1.1 #732

merged 1 commit into from
May 22, 2024

Conversation

dprotaso
Copy link
Contributor

Gateway Conformance tests weren't running properly

/home/prow/go/pkg/mod/sigs.k8s.io/[email protected]/conformance/tests/httproute-weight.go:29:2: missing go.sum entry for module providing package golang.org/x/sync/errgroup (imported by sigs.k8s.io/gateway-api/conformance/tests); to add:
go get sigs.k8s.io/gateway-api/conformance/[email protected]

/assign @izabelacg

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@knative-prow knative-prow bot requested review from krsna-m and upodroid May 21, 2024 16:57
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2024
ReToCode
ReToCode approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 80dea62 into knative-extensions:main May 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@izabelacg izabelacg

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @ReToCode @izabelacg