-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Gateway API v1.1 #734
Bump Gateway API v1.1 #734
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
=======================================
Coverage 79.12% 79.12%
=======================================
Files 17 17
Lines 1260 1260
=======================================
Hits 997 997
Misses 227 227
Partials 36 36 ☔ View full report in Codecov by Sentry. |
36f5efc
to
ab8f57f
Compare
/test integration-tests-contour_net-gateway-api_main |
/assign @izabelacg This is ready - but the diff is too large so a bunch of checks fail - we can ignore those. For me the main thing is the integration tests pass. |
ab8f57f
to
8cd0a8b
Compare
/lgtm |
Overriding broken jobs - diff is to large and reviewdog breaks /override "style / Golang / Lint" |
@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "patch" |
@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "style / Golang / Lint" |
@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Boilerplate Check (go), style / Golang / Boilerplate Check (sh), style / Golang / Do Not Submit, style / Golang / Lint, style / suggester / shell In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1058d9e
into
knative-extensions:main
Trying to redo - #729