Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gateway API v1.1 #734

Merged
merged 4 commits into from
May 31, 2024

Conversation

dprotaso
Copy link
Contributor

Trying to redo - #729

Copy link

knative-prow bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (f8ed9a7) to head (8cd0a8b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files          17       17           
  Lines        1260     1260           
=======================================
  Hits          997      997           
  Misses        227      227           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso dprotaso changed the title Bump Gateway API v1.1 [wip] Bump Gateway API v1.1 May 23, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

@dprotaso dprotaso changed the title [wip] Bump Gateway API v1.1 Bump Gateway API v1.1 May 29, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024
@dprotaso
Copy link
Contributor Author

/assign @izabelacg

This is ready - but the diff is too large so a bunch of checks fail - we can ignore those. For me the main thing is the integration tests pass.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@dprotaso
Copy link
Contributor Author

Overriding broken jobs - diff is to large and reviewdog breaks

/override "style / Golang / Lint"
/override "style / Golang / Do Not Submit"
/override "style / Golang / Boilerplate Check (go)"
/override "style / Golang / Boilerplate Check (sh)"
/override "style / suggester / shell"
/override "codecov/patch"

Copy link

knative-prow bot commented May 31, 2024

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/patch

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Generate some code!
  • build-tests_net-gateway-api_main
  • integration-tests-contour_net-gateway-api_main
  • integration-tests-istio_net-gateway-api_main
  • style / Golang / Boilerplate Check (go)
  • style / Golang / Boilerplate Check (sh)
  • style / Golang / Do Not Submit
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_net-gateway-api_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

Overriding broken jobs - diff is to large and reviewdog breaks

/override "style / Golang / Lint"
/override "style / Golang / Do Not Submit"
/override "style / Golang / Boilerplate Check (go)"
/override "style / Golang / Boilerplate Check (sh)"
/override "style / suggester / shell"
/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Contributor Author

/override "patch"

Copy link

knative-prow bot commented May 31, 2024

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • patch

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Generate some code!
  • build-tests_net-gateway-api_main
  • integration-tests-contour_net-gateway-api_main
  • integration-tests-istio_net-gateway-api_main
  • style / Golang / Boilerplate Check (go)
  • style / Golang / Boilerplate Check (sh)
  • style / Golang / Do Not Submit
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_net-gateway-api_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso dprotaso closed this May 31, 2024
@dprotaso dprotaso reopened this May 31, 2024
@dprotaso
Copy link
Contributor Author

/override "style / Golang / Lint"
/override "style / Golang / Do Not Submit"
/override "style / Golang / Boilerplate Check (go)"
/override "style / Golang / Boilerplate Check (sh)"
/override "style / suggester / shell"

Copy link

knative-prow bot commented May 31, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Boilerplate Check (go), style / Golang / Boilerplate Check (sh), style / Golang / Do Not Submit, style / Golang / Lint, style / suggester / shell

In response to this:

/override "style / Golang / Lint"
/override "style / Golang / Do Not Submit"
/override "style / Golang / Boilerplate Check (go)"
/override "style / Golang / Boilerplate Check (sh)"
/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 1058d9e into knative-extensions:main May 31, 2024
44 of 54 checks passed
@dprotaso dprotaso deleted the bump-gateway-api branch May 31, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants