Please run goimports. diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index 68d4777..1f504c5 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -18,9 +18,10 @@ package main import ( "context" - sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1" "os" + sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1" + "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/kubernetes/scheme"

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_conversion.go b/pkg/apis/sources/v1alpha1/integration_conversion.go index 6b0235d..32bfc7c 100644 --- a/pkg/apis/sources/v1alpha1/integration_conversion.go +++ b/pkg/apis/sources/v1alpha1/integration_conversion.go @@ -19,6 +19,7 @@ package v1alpha1 import ( "context" "fmt" + "knative.dev/pkg/apis" )

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_conversion_test.go b/pkg/apis/sources/v1alpha1/integration_conversion_test.go index 93d712e..2272ecc 100644 --- a/pkg/apis/sources/v1alpha1/integration_conversion_test.go +++ b/pkg/apis/sources/v1alpha1/integration_conversion_test.go @@ -19,8 +19,9 @@ package v1alpha1 import ( "context" "errors" - "knative.dev/pkg/apis" "testing" + + "knative.dev/pkg/apis" ) // implement apis.Convertible

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_defaults_test.go b/pkg/apis/sources/v1alpha1/integration_defaults_test.go index 3497c91..ed58649 100644 --- a/pkg/apis/sources/v1alpha1/integration_defaults_test.go +++ b/pkg/apis/sources/v1alpha1/integration_defaults_test.go @@ -18,8 +18,9 @@ package v1alpha1 import ( "context" - "github.com/google/go-cmp/cmp" "testing" + + "github.com/google/go-cmp/cmp" ) func TestSetDefaults(t *testing.T) {

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go b/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go index 1b88bf1..26b2a00 100644 --- a/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go +++ b/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go @@ -17,13 +17,14 @@ limitations under the License. package v1alpha1 import ( + "testing" + "github.com/google/go-cmp/cmp" "github.com/google/go-cmp/cmp/cmpopts" corev1 "k8s.io/api/core/v1" v1 "knative.dev/eventing/pkg/apis/sources/v1" "knative.dev/pkg/apis" duckv1 "knative.dev/pkg/apis/duck/v1" - "testing" ) var (

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_validation.go b/pkg/apis/sources/v1alpha1/integration_validation.go index 5d2a28e..4df223e 100644 --- a/pkg/apis/sources/v1alpha1/integration_validation.go +++ b/pkg/apis/sources/v1alpha1/integration_validation.go @@ -18,6 +18,7 @@ package v1alpha1 import ( "context" + "knative.dev/pkg/apis" )

Please run goimports. diff --git a/pkg/reconciler/integrationsource/controller.go b/pkg/reconciler/integrationsource/controller.go index 632c40b..4fa32e2 100644 --- a/pkg/reconciler/integrationsource/controller.go +++ b/pkg/reconciler/integrationsource/controller.go @@ -18,6 +18,7 @@ package integrationsource import ( "context" + "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/tools/cache"

Please run goimports. diff --git a/pkg/reconciler/integrationsource/integrationsource.go b/pkg/reconciler/integrationsource/integrationsource.go index 9873568..d9dbda6 100644 --- a/pkg/reconciler/integrationsource/integrationsource.go +++ b/pkg/reconciler/integrationsource/integrationsource.go @@ -3,6 +3,7 @@ package integrationsource import ( "context" "fmt" + "go.uber.org/zap" corev1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/equality"

Please run goimports. diff --git a/pkg/reconciler/integrationsource/resources/containersource.go b/pkg/reconciler/integrationsource/resources/containersource.go index 127305f..f981dbf 100644 --- a/pkg/reconciler/integrationsource/resources/containersource.go +++ b/pkg/reconciler/integrationsource/resources/containersource.go @@ -2,14 +2,15 @@ package resources import ( "fmt" + "reflect" + "strconv" + "strings" + corev1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" sourcesv1 "knative.dev/eventing/pkg/apis/sources/v1" "knative.dev/eventing/pkg/apis/sources/v1alpha1" "knative.dev/pkg/kmeta" - "reflect" - "strconv" - "strings" ) func NewContainerSource(source *v1alpha1.IntegrationSource) *sourcesv1.ContainerSource {

Please run goimports. diff --git a/test/rekt/features/integrationsource/features.go b/test/rekt/features/integrationsource/features.go index 74c5e44..a6578f7 100644 --- a/test/rekt/features/integrationsource/features.go +++ b/test/rekt/features/integrationsource/features.go @@ -2,6 +2,7 @@ package integrationsource import ( "context" + "github.com/cloudevents/sdk-go/v2/test" "knative.dev/eventing/pkg/eventingtls/eventingtlstesting" "knative.dev/eventing/test/rekt/features/featureflags"

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integrationsource/integrationsource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integrationsource/resources/containersource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/reconciler/integrationsource/resources/labels.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: test/rekt/features/integrationsource/features.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: test/rekt/resources/integrationsource/integrationsource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

Process completed with exit code 1.

func `makeBasicEnvVar` is unused (unused)

const `controllerAgentName` is unused (unused)

const `component` is unused (unused)

issues found

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum