Please run goimports. diff --git a/cmd/controller/main.go b/cmd/controller/main.go index bfca7ca..03dd21d 100644 --- a/cmd/controller/main.go +++ b/cmd/controller/main.go @@ -21,13 +21,14 @@ import ( // _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" "errors" - integrationSink "knative.dev/eventing/pkg/reconciler/integration/sink" - integrationSource "knative.dev/eventing/pkg/reconciler/integration/source" "log" "net/http" "os" "time" + integrationSink "knative.dev/eventing/pkg/reconciler/integration/sink" + integrationSource "knative.dev/eventing/pkg/reconciler/integration/source" + "knative.dev/pkg/injection/sharedmain" filteredFactory "knative.dev/pkg/client/injection/kube/informers/factory/filtered"

Please run goimports. diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index fddd03f..76dc703 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -18,9 +18,10 @@ package main import ( "context" - sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1" "os" + sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1" + "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/kubernetes/scheme"

Please run goimports. diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_defaults_test.go b/pkg/apis/sinks/v1alpha1/integration_sink_defaults_test.go index 41bdc31..fd60580 100644 --- a/pkg/apis/sinks/v1alpha1/integration_sink_defaults_test.go +++ b/pkg/apis/sinks/v1alpha1/integration_sink_defaults_test.go @@ -18,8 +18,9 @@ package v1alpha1 import ( "context" - "github.com/google/go-cmp/cmp" "testing" + + "github.com/google/go-cmp/cmp" ) func TestIntegrationSinkSetDefaults(t *testing.T) {

Please run goimports. diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_lifecycle_test.go b/pkg/apis/sinks/v1alpha1/integration_sink_lifecycle_test.go index 4cb2902..a7cfeee 100644 --- a/pkg/apis/sinks/v1alpha1/integration_sink_lifecycle_test.go +++ b/pkg/apis/sinks/v1alpha1/integration_sink_lifecycle_test.go @@ -17,11 +17,12 @@ limitations under the License. package v1alpha1 import ( + "testing" + "github.com/google/go-cmp/cmp" corev1 "k8s.io/api/core/v1" "knative.dev/pkg/apis" duckv1 "knative.dev/pkg/apis/duck/v1" - "testing" ) func TestIntegrationSinkGetConditionSet(t *testing.T) {

Please run goimports. diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_types_test.go b/pkg/apis/sinks/v1alpha1/integration_sink_types_test.go index d148aa2..c35bf59 100644 --- a/pkg/apis/sinks/v1alpha1/integration_sink_types_test.go +++ b/pkg/apis/sinks/v1alpha1/integration_sink_types_test.go @@ -17,8 +17,9 @@ limitations under the License. package v1alpha1 import ( - "knative.dev/eventing/pkg/apis/common" "testing" + + "knative.dev/eventing/pkg/apis/common" ) func TestIntegrationSink_GetStatus(t *testing.T) {

Please run goimports. diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_validation.go b/pkg/apis/sinks/v1alpha1/integration_sink_validation.go index 40d0231..202df43 100644 --- a/pkg/apis/sinks/v1alpha1/integration_sink_validation.go +++ b/pkg/apis/sinks/v1alpha1/integration_sink_validation.go @@ -18,6 +18,7 @@ package v1alpha1 import ( "context" + "knative.dev/pkg/apis" )

Please run goimports. diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_validation_test.go b/pkg/apis/sinks/v1alpha1/integration_sink_validation_test.go index d984ead..8e346fd 100644 --- a/pkg/apis/sinks/v1alpha1/integration_sink_validation_test.go +++ b/pkg/apis/sinks/v1alpha1/integration_sink_validation_test.go @@ -18,9 +18,10 @@ package v1alpha1 import ( "context" - "knative.dev/eventing/pkg/apis/common" "testing" + "knative.dev/eventing/pkg/apis/common" + "github.com/google/go-cmp/cmp" "knative.dev/pkg/apis" )

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_conversion.go b/pkg/apis/sources/v1alpha1/integration_conversion.go index 6b0235d..32bfc7c 100644 --- a/pkg/apis/sources/v1alpha1/integration_conversion.go +++ b/pkg/apis/sources/v1alpha1/integration_conversion.go @@ -19,6 +19,7 @@ package v1alpha1 import ( "context" "fmt" + "knative.dev/pkg/apis" )

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_conversion_test.go b/pkg/apis/sources/v1alpha1/integration_conversion_test.go index 93d712e..2272ecc 100644 --- a/pkg/apis/sources/v1alpha1/integration_conversion_test.go +++ b/pkg/apis/sources/v1alpha1/integration_conversion_test.go @@ -19,8 +19,9 @@ package v1alpha1 import ( "context" "errors" - "knative.dev/pkg/apis" "testing" + + "knative.dev/pkg/apis" ) // implement apis.Convertible

Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_defaults_test.go b/pkg/apis/sources/v1alpha1/integration_defaults_test.go index 3497c91..ed58649 100644 --- a/pkg/apis/sources/v1alpha1/integration_defaults_test.go +++ b/pkg/apis/sources/v1alpha1/integration_defaults_test.go @@ -18,8 +18,9 @@ package v1alpha1 import ( "context" - "github.com/google/go-cmp/cmp" "testing" + + "github.com/google/go-cmp/cmp" ) func TestSetDefaults(t *testing.T) {

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integration/helper.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integration/sink/controller.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integration/sink/integrationsink.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integration/sink/resources/container_image.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/reconciler/integration/sink/resources/labels.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integration/source/resources/containersource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/reconciler/integration/source/resources/labels.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: test/rekt/features/integrationsource/features.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: test/rekt/resources/integrationsource/integrationsource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

Process completed with exit code 1.

const `controllerAgentName` is unused (unused)

const `controllerAgentName` is unused (unused)

SA9003: empty branch (staticcheck)

SA9003: empty branch (staticcheck)

issues found

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum