Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the skip on PingSource rek-test #5418

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Removing the skip on PingSource rek-test #5418

merged 1 commit into from
Jun 7, 2021

Conversation

matzew
Copy link
Member

@matzew matzew commented May 19, 2021

Signed-off-by: Matthias Wessendorf [email protected]

Fixes #5375

Proposed Changes

  • remove skip, to see if still flaky

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@matzew
Removing the skip
bd23afb 
Signed-off-by: Matthias Wessendorf <[email protected]>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2021
@matzew
Copy link
Member Author

matzew commented May 19, 2021

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@matzew matzew changed the title Removing the skip Removing the skip on PingSource rek-test May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021 •
edited
Loading

Codecov Report

Merging #5418 (bd23afb) into main (23198cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5418   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         194      194           
  Lines        5987     5987           
=======================================
  Hits         4947     4947           
  Misses        717      717           
  Partials      323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23198cd...bd23afb. Read the comment docs.

@benmoss
Copy link
Member

benmoss commented May 20, 2021 •
edited
Loading

/test pull-knative-eventing-reconciler-tests

this failure looks like the same that hopefully was fixed by #5419

@benmoss
Copy link
Member

benmoss commented May 20, 2021

/test pull-knative-eventing-reconciler-tests

looks good so far 😄

@benmoss
Copy link
Member

benmoss commented May 21, 2021

/test pull-knative-eventing-reconciler-tests

@aliok
Copy link
Member

aliok commented May 25, 2021

/test all

Let's test once more and merge

aliok
aliok approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 25, 2021
@matzew
Copy link
Member Author

matzew commented May 25, 2021

and than TestApiServerSourceDataPlane_ResourceMatching failed again 🙄

/hold

/test pull-knative-eventing-reconciler-tests

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2021
@aliok
Copy link
Member

aliok commented May 25, 2021

can you comment that test? I wrote that test, gonna look into it. ...later

@matzew
Copy link
Member Author

matzew commented May 25, 2021

can you comment that test? I wrote that test, gonna look into it. ...later

You mean comment out? I prefer skip instead of commenting out

@matzew
Copy link
Member Author

matzew commented May 25, 2021

/test pull-knative-eventing-reconciler-tests

@aliok
Copy link
Member

aliok commented May 26, 2021

I meant skip OR comment out

aliok
aliok approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented May 26, 2021

/test all

🙈

@matzew
Copy link
Member Author

matzew commented Jun 7, 2021

/test all

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2021
@knative-prow-robot knative-prow-robot merged commit db83525 into knative:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky API Server Source rekt test
4 participants
@matzew @benmoss @aliok @knative-prow-robot