Do not remove the resources if status.Manifests is empty (#1665)

Co-authored-by: Vincent Hou <[email protected]>
knative · Jan 9, 2024 · 605847f · 605847f
1 parent 2e186fe
commit 605847f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/reconciler/knativeeventing/knativeeventing.go b/pkg/reconciler/knativeeventing/knativeeventing.go
@@ -169,6 +169,9 @@ func (r *Reconciler) injectNamespace(ctx context.Context, manifest *mf.Manifest,
 
 func (r *Reconciler) installed(ctx context.Context, instance base.KComponent) (*mf.Manifest, error) {
 	paths := instance.GetStatus().GetManifests()
+	if len(paths) == 0 {
+		return nil, nil
+	}
 	installed, err := common.FetchManifestFromArray(paths)
 
 	if err != nil {

diff --git a/pkg/reconciler/knativeserving/knativeserving.go b/pkg/reconciler/knativeserving/knativeserving.go
@@ -155,6 +155,9 @@ func (r *Reconciler) injectNamespace(ctx context.Context, manifest *mf.Manifest,
 
 func (r *Reconciler) installed(ctx context.Context, instance base.KComponent) (*mf.Manifest, error) {
 	paths := instance.GetStatus().GetManifests()
+	if len(paths) == 0 {
+		return nil, nil
+	}
 	installed, err := common.FetchManifestFromArray(paths)
 	if err != nil {
 		return &installed, err