Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cluster version to 1.28 #1712

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Fix the cluster version to 1.28 #1712

merged 3 commits into from
Feb 22, 2024

Conversation

houshengbo
Copy link
Contributor

No description provided.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 21, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (8c9c8d0) to head (7ccaee4).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1712   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files          41       41           
  Lines        1857     1857           
=======================================
  Hits         1474     1474           
  Misses        279      279           
  Partials      104      104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo houshengbo changed the title Fix the cluster version Fix the cluster version to 1.28 Feb 21, 2024
@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

1 similar comment
@matzew
Copy link
Member

matzew commented Feb 22, 2024

/test eventing-upgrade-tests

matzew
matzew reviewed Feb 22, 2024
View reviewed changes
config/manager/operator.yaml Outdated
@@ -55,7 +55,7 @@ spec:
- name: CONFIG_OBSERVABILITY_NAME
value: config-observability
- name: KUBERNETES_MIN_VERSION
value: ""
value: "1.24.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it empty before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was and will be empty. We would like to offer a way to override the kube version. If it is empty, it will default to the value knative/pkg sets.

@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@knative-prow knative-prow bot merged commit 80fcb5b into knative:main Feb 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@maximilien maximilien Awaiting requested review from maximilien

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houshengbo @matzew