Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the additional line #1718

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Removed the additional line #1718

merged 3 commits into from
Feb 27, 2024

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Feb 26, 2024 •
edited
Loading

Proposed Changes

  • Tried out to see of the CI prow is flaky.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (fdfa04b) to head (ef4038c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   63.60%   63.60%           
=======================================
  Files          53       53           
  Lines        2580     2580           
=======================================
  Hits         1641     1641           
  Misses        825      825           
  Partials      114      114

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

1 similar comment
@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2024
@houshengbo
Copy link
Contributor Author

/retest

@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@knative-prow knative-prow bot merged commit 87b465c into knative:main Feb 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@maximilien maximilien Awaiting requested review from maximilien

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@houshengbo