Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable via regex in chaosduck #2117

Merged
merged 1 commit into from
May 11, 2021

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented May 10, 2021

Changes

It's been kinda annoying trying to come up with the exact list of webhooks to ignore and this has caused intermediate flakiness. This adds the possibility to exclude components via a regex, so all webhooks can be excluded more easily and scalably.

/assign @nak3 @dprotaso

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 10, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #2117 (0c495c9) into main (132b1e7) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 0c495c9 differs from pull request most recent head ee65ce5. Consider uploading reports for the commit ee65ce5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
+ Coverage   67.39%   67.44%   +0.04%     
==========================================
  Files         215      215              
  Lines        9116     9116              
==========================================
+ Hits         6144     6148       +4     
+ Misses       2697     2695       -2     
+ Partials      275      273       -2     
Impacted Files Coverage Δ
test/gcs/mock/mock.go 92.47% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132b1e7...ee65ce5. Read the comment docs.

@nak3
Copy link
Contributor

nak3 commented May 10, 2021

LGTM

@dprotaso
Copy link
Member

can we have disabledComponents accept a regex?

@markusthoemmes
Copy link
Contributor Author

I thought about that @dprotaso, but eventually opted for the easier solution. I'll take another look.

@markusthoemmes markusthoemmes changed the title Skip all webhooks in chaos duck Allow disable via regex in chaosduck May 11, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2021
@markusthoemmes
Copy link
Contributor Author

/retest

Unrelated.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@markusthoemmes
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 620e8d2 into knative:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants