Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluse domainmapping-webhook from chaos #11202

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Excluse domainmapping-webhook from chaos #11202

merged 1 commit into from
Apr 15, 2021

Conversation

julz
Copy link
Member

@julz julz commented Apr 15, 2021

.. for same reasons as excluding regular webhook (see knative/pkg#1509).

/assign @markusthoemmes

@julz
Excluse domainmapping-webhook from chaos
2aefea5 
.. for same reasons as excluding regular webhook.
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 15, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
markusthoemmes
markusthoemmes approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #11202 (2aefea5) into main (09f07d7) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11202      +/-   ##
==========================================
+ Coverage   87.63%   87.67%   +0.04%     
==========================================
  Files         191      191              
  Lines        9193     9193              
==========================================
+ Hits         8056     8060       +4     
+ Misses        883      880       -3     
+ Partials      254      253       -1
Impacted Files Coverage Δ
pkg/activator/net/revision_backends.go 92.01% <0.00%> (+0.93%) ⬆️
pkg/reconciler/configuration/configuration.go 88.28% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f07d7...2aefea5. Read the comment docs.

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2021
@julz
Copy link
Member Author

julz commented Apr 15, 2021

dammit can't spell "exclude". oh well :).

@dprotaso
Copy link
Member

For the 'runs' that failed with EOF can you post them on the pkg issue for reference. I need to revisit that

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/retest

1 similar comment
@julz
Copy link
Member Author

julz commented Apr 15, 2021

/retest

@julz
Copy link
Member Author

julz commented Apr 15, 2021

/test pull-knative-serving-istio-stable-no-mesh

@julz
Copy link
Member Author

julz commented Apr 15, 2021

/retest

@julz
Copy link
Member Author

julz commented Apr 15, 2021

so close!

/retest

@julz
Copy link
Member Author

julz commented Apr 15, 2021

/retest

@knative-prow-robot knative-prow-robot merged commit 935bcc8 into knative:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Assignees

@dprotaso dprotaso

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julz @dprotaso @knative-prow-robot @markusthoemmes