Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

130 1 package update #136

Merged
merged 70 commits into from
Jun 20, 2021
Merged

130 1 package update #136

merged 70 commits into from
Jun 20, 2021

Conversation

brianmhunt
Copy link
Member

Implementation of #130

brianmhunt and others added 30 commits April 23, 2021 22:50
@brianmhunt
update tslib dependency in packages/*/package.json
3234d23
@brianmhunt
add Makefile to .editorconfig
c0dd8e6
@brianmhunt
update packages and lerna config
5e4aea3
@brianmhunt
update base tsconfig target to ES6
48e6f19
@brianmhunt
add several Makefile targets and tools/build.mk with sample esbuild c…
c163abb 
…onfig
@brianmhunt
rough-out makefiles with peer dependency compilation
1a4e8cf
@brianmhunt
change peer dependencies to newlines that seem to work better with Ma…
cf7cf17 
…kefile targets
@brianmhunt
Update make targets for proper Makefile cross-package dependencies
8482a4e
@brianmhunt
add the commonjs/esm targets
4eacc1c
@brianmhunt
add tools for the package template
a58c7cc
@brianmhunt
remove references to config.yaml
d365509
@brianmhunt
update Makefile for repackaging; pull package version from lerna.json…
226ea23 
… (for now)
@brianmhunt
repackage all package.json files
b1f0cfc 
.. removing `scripts`, `standard`, and other unused package.json fields
@brianmhunt
remove standard from repackage
e9acdc0
@brianmhunt
improve logging and peer dependency checking
a058c17
@brianmhunt
Remove numerous references to rollup
8084925 
... and the many workarounds that are now replaced by esbuild
@brianmhunt
make) update the Makefile test targets
e833d23 
and add test_{package}
@brianmhunt
update repackage to export "." and "./helpers"
5ef35fd
@brianmhunt
repackage with dist/index.js as esm import, dist/index.cjs commonjs
fffde54
@brianmhunt
Fix build/peer dependencies building
20d0fdf
@brianmhunt
Fix karma testing config for esbuild
df1b282
@brianmhunt
Fix top-level Makefile packaging
1306599
@brianmhunt
Fix utils.jsx imports / dependencies
6ed2878
@brianmhunt
make) add esm dependency to testing; add watch target
6ed1bde
@brianmhunt
change spec imports from ../src to ../dist
ba417f7 
... so we don't have a double-import problem
@brianmhunt
consolidate the karma config to tools/karma.conf.js
0bddb03
@brianmhunt
fix builder missing karma/frameworks
6b20562
@brianmhunt
tools) fix broken ../{pkg}/dist/*.js
6404e84
@brianmhunt
Move packages/build.knockout to builds/knockout
39b90b9
@brianmhunt
Move packages/build.reference to builds/reference
1291eb0
brianmhunt and others added 27 commits May 25, 2021 22:32
@brianmhunt
Updated config.yml
cd2c37b
@brianmhunt
ci) add job
8216b95
@brianmhunt
Merge branch '130-1-package-update' of github.com:knockout/tko into 1…
d9f0a47 
…30-1-package-update
@brianmhunt
ci) add make ci target and Github workflow
938b78a
@brianmhunt
ci) fix make target
f04a642
@brianmhunt
bind) clean up some imports
a626e59
@brianmhunt
ci) remove peer devDependencies from the monorepo that are used for t…
b2fcedf 
…ests

... because lerna seems to order its topology by dependencies and devDependencies as equivalent
@brianmhunt
make) change lerna concurrency to a variable
511c84a
@brianmhunt
Merge branch '130-1-package-update' of github.com:knockout/tko into 1…
993ec30 
…30-1-package-update
@brianmhunt
Merge branch '130-1-package-update' of github.com:knockout/tko into 1…
35a6c80 
…30-1-package-update
@brianmhunt
Merge branch '130-1-package-update' of github.com:knockout/tko into 1…
065fe26 
…30-1-package-update
@brianmhunt
Revert "ci) remove peer devDependencies from the monorepo that are us…
43e55c4 
…ed for tests"

This reverts commit b2fcedf.
@brianmhunt
ci) use concurrency=1 for build/exec
1eb9949
@brianmhunt
ci) change devDependencies to dependencies or peerDependencies
6381563 
... to avoid circular loops in the Lerna topology algorithm
@brianmhunt
make) ensure that the node_modules is built
beb0072
@brianmhunt
workflows) switch to node 16
20027ba
@brianmhunt
ci) add sauce env vars
958faec
@brianmhunt
ci) remove package-lock.json dupe; start to simplify SauceLabs config
8f618ba
@brianmhunt
ci) disable startConnect by default
f91df81
@brianmhunt
ci) disable Safari as it always tseems to time out
c992c89
@brianmhunt
ci) disable SauceLabs, enable local testing
e21b187 
... so we're no longer blocked
@brianmhunt
ci) disable SL on pull; set test concurrency=1
6acae6d
@brianmhunt
ci) try xvfb-run on Github actions
17164cd 
per:

juliangruber/browser-run#147
@brianmhunt
ci) install electron / npm
8d6a9b0
@brianmhunt
ci) try GabrielBB/xvfb-action tests
6100608
@brianmhunt
ci) switch back to SauceLabs w/o recording/screenshots
63fcdcc 
... also set test concurrency to 1
@brianmhunt
ci) disable CI altogether until we DD it
91abdbe
@brianmhunt
Copy link
Member Author

This largely subsumes #111 but there's code in there we'll want to merge forward.

There's a good chance there's a ton of things that we'll want to additionally merge to fix this code-path up, but we've got to take a bit of a leap of faith and merge in this branch and start tackling things in smaller, more digestible PRs.

@brianmhunt brianmhunt merged commit e9c39cc into master Jun 20, 2021
@brianmhunt brianmhunt deleted the 130-1-package-update branch June 20, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianmhunt