live training for recruits
- Access to this repository, member status in knr-auv organization
- Visual Studio Code - Code Editor
- VSCode extensions listed in wiki Styles
- Conda
- Docs - styling configuration, conda installation, dual boot install...
- Example of workflow - you can check how actual workflow looks on work done by @miki87278 or @mpfmorawski,
which was reviewed by @niemiaszek for autonomy repository.
- Make sure you have setup everything listed in preliminaries
- Prepare SSH key for your PC, so you can actually clone repos via ssh key and easily add your changes in knr-auv.
Follow this tutorial from GitHub - Add the key to your GitHub account. Again, tutorial by Github
- Check if your key was succesfully added, trying to clone this repository with SSH
- Now its time for your main task. Your task will be "fixing" the
add-ugly-code
branch.
It can be viewed via GitHub or locally. - Firstly, create remote branch with naming
<your_nickname>/fix-ugly-code
. Make sure your new branch hasadd-ugly-code
branch as a parent. - Then, pull your local repository, so it will be aware of your new branch existance.
git pull
- Once done, checkout to your new remote branch. You should see actual code appearing in your local directory.
- Setup your Conda environment and add correct interpreter to VSC.
- Now you can work on actual fix.
- Try to fix problems suggested by PyLint.
- Apply Black and isort formatting (should work just by
ctrl+s
if you setup VSC extensions correctly). - Make code runnable without errors (run it with python). This way you can see, if your Conda environment is set up correctly.
- If you are happy with your fix, stage and commit your changes with a message
- Push your local changes to remote branch (just
git push
) - You should now see your changes on GitHub branch if everything went as planned.
As a final step, open Pull Request from your branch toadd-ugly-code
and add @niemiaszek as a reviewer