Merge pull request #109 from koaning/testlite

i really feel like removing some deps
koaning · Sep 12, 2024 · 002afe6 · 002afe6
2 parents b047485 + 888265a
commit 002afe6
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 67 deletions.
diff --git a/.github/workflows/unittest.yml b/.github/workflows/unittest.yml
@@ -14,24 +14,22 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.11"]
+        python-version: ["3.9", "3.11"]
 
     steps:
     - uses: actions/checkout@v2
+    - name: Install uv
+      uses: astral-sh/setup-uv@v2
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v1
-      with:
-        python-version: ${{ matrix.python-version }}
-        cache: 'pip'
+      run: uv python install ${{ matrix.python-version }}
+    - name: Set up venv
+      run: uv venv
     - name: Install Base Dependencies
-      run: python -m pip install -e .
-    - name: Install Testing Dependencies
-      run: make install
+      run: uv pip install -e '.[dev]'
     - name: Prep CI tests
       run: |
-        mkdir ~/.cache/bpemb
-        mkdir ~/.cache/bpemb/en
+        mkdir -p ~/.cache/bpemb/en
         mv tests/data/en.wiki.bpe.vs1000.d25.w2v.bin ~/.cache/bpemb/en
         mv tests/data/en.wiki.bpe.vs1000.model ~/.cache/bpemb/en
     - name: Unittest
-      run: make test
+      run: uv run pytest -n auto -vv
diff --git a/docs/finetuners.md → docs/finetuners.removed-md b/docs/finetuners.md → docs/finetuners.removed-md
diff --git a/setup.py b/setup.py
@@ -14,9 +14,8 @@
 bpemb_packages = ["bpemb>=0.3.3"]
 spacy_packages = ["spacy>=3.5.0"]
 gensim_packages = ["gensim>=4.3.1", "scipy<1.13.0"]
-keras_nlp_packages = ["keras-nlp>=0.6.0"]
 
-text_packages = sense2vec_pkgs + bpemb_packages + gensim_packages + keras_nlp_packages
+text_packages = sense2vec_pkgs + bpemb_packages + gensim_packages
 
 vision_packages = ["timm>=0.6.7"]
 
@@ -71,7 +70,6 @@
         "gensim": gensim_packages + base_packages,
         "sense2vec": sense2vec_pkgs + base_packages,
         "spacy": spacy_packages + base_packages,
-        "keras_nlp": keras_nlp_packages + base_packages,
         "bpemb": bpemb_packages + base_packages,
         "text": text_packages + base_packages,
         "vision": vision_packages + base_packages,

diff --git a/tests/test_default.py b/tests/test_default.py
diff --git a/tests/test_finetuners.py b/tests/test_finetuners.py
diff --git a/tests/test_text.py b/tests/test_text.py
@@ -116,22 +116,3 @@ def test_basic_spacy_cached(nlp, tmpdir):
     output_after = encoder.transform(test_sentences)
     assert (output_before == output_during).all()
     assert (output_during == output_after).all()
-
-
-def test_lite_encoder_basics(tmp_path):
-    generator_of_strings = (
-        ex["text"] for ex in srsly.read_jsonl("datasets/new-dataset.jsonl")
-    )
-    path = tmp_path / "out.skops"
-    examples = ["encode this examples", "and this one"]
-
-    # Train something
-    enc_orig = learn_lite_text_embeddings(generator_of_strings, path=path, dim=100)
-    orig = enc_orig.transform(examples)
-
-    # Reload it
-    enc_reload = LiteTextEncoder(path=path)
-    new = enc_reload.transform(examples)
-
-    assert np.isclose(orig, new).all()
-    assert orig.shape[1] == 100