Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ode sycl fix #2423

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Ode sycl fix #2423

merged 3 commits into from
Nov 8, 2024

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Nov 8, 2024

Excluding the Henderson autocatalytic ODE from the set of tests on the SYCL backend. This fails on Blake PVC node while it passes on Aurora. The issue could be related to the hardware or the toolchain, hard to diagnose at this point...

@lucbv lucbv self-assigned this Nov 8, 2024
For the time being it is unclear why this particular case
leads to a runtime error from the SYCL API?

Signed-off-by: Luc Berger-Vergiat <[email protected]>
Signed-off-by: Luc Berger-Vergiat <[email protected]>
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucbv !

@ndellingwood
Copy link
Contributor

Cross-reference #2414

@ndellingwood ndellingwood merged commit fa587df into kokkos:develop Nov 8, 2024
21 checks passed
ndellingwood pushed a commit that referenced this pull request Nov 11, 2024
* ODE: skipping autocatalytic test on SYCL

For the time being it is unclear why this particular case
leads to a runtime error from the SYCL API?

Signed-off-by: Luc Berger-Vergiat <[email protected]>

* ODE: formatting

Signed-off-by: Luc Berger-Vergiat <[email protected]>

* ODE: forgot to check if the SYCL space is enabled in Kokkos

Signed-off-by: Luc Berger-Vergiat <[email protected]>

---------

Signed-off-by: Luc Berger-Vergiat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants