deprecate KOKKOS_CUSPARSE_SAFE_CALL -> KOKKOSPARSE_IMPL_CUSPARSE_SAFE_CALL #2426
Conversation
| ArrayType& operator=(const ArrayType& rhs_) { | ||
| if (this != &rhs_) { | ||
| for (size_type i = 0; i < MAX_VEC_SIZE; ++i) { | ||
| m_data[i] = rhs_.m_data[i]; | ||
| } | ||
| ArrayType &operator=(const ArrayType &rhs_) { | ||
| if (this != &rhs_) { | ||
| for (size_type i = 0; i < MAX_VEC_SIZE; ++i) { | ||
| m_data[i] = rhs_.m_data[i]; | ||
| } | ||
| return *this; | ||
| } | ||
| return *this; |
There was a problem hiding this comment.
ok, maybe this is a clang-format/git artifact
There was a problem hiding this comment.
yes this is formatting related, I’m not sure why it wasn’t formatted before.
|
Something strange going on in the mi210 without TPLs, the tests are all reporting a segfault. |
|
I used Visual Studio Code’s global search/replace, except for the area where I implemented the deprecation macro. |
| // The macro below defines is the public interface for the safe cusparse calls. | ||
| // The functions themselves are protected by impl namespace. |
There was a problem hiding this comment.
I think the comment should be revised.
I could not find any documentation of the macro as part of the public interface. Do you know of anyone using it? Do you want to have the old one around but emit a deprecation warning instead of removing it?
There was a problem hiding this comment.
I somehow missed pushing the deprecation part, it's in now.
|
Looks like Trilinos has one use in Ifpack2: |
cwpearson
force-pushed
the
fix/2371
branch
3 times, most recently
from
32d3c9c
to
d8bac27
Compare
…_CALL Signed-off-by: Carl Pearson <[email protected]>
Fix for #2371