Update cmtestallsandia

* Fix kokkos#2130

- Do not call BsrMatrix spmv impl if block size is 1
- Instead, convert it to unmanaged CrsMatrix and call spmv again
  - cuSPARSE returned an error code in this case
  - Better performance

* Formatting

* Remove redundant remove_pointer_t

Handle is already a non-pointer type

…s#2135)

This could be further automated to run on matrix from suite sparse

…okkos#2133)

Since we are now in the 4.2 series we only support up to 4.1.00.
Older version of Kokkos Core will require older version of Kokkos
Kernels for compatibility. Once 4.3.00 is out we will move to
drop support for the 4.1 series and only keep 4.2 and 4.3 series.

* ODE: adding BDF algorithms

Implementing BDF formula for stiff ODEs.
Orders 1 to 5 are available and tested.
The integrators can be called on GPU to
solve multiple systems in parallel.

* ODE: fixing storage handling for start-up RK stack

* ODE: clang-format

* ODE: first adaptive version of BDF

The current implementation only allows for adaptivity in time,
at this point the BDF Step actually converges as expected with
first order integration!

* ODE: fixing issues with adaptive BDF

The unit-test BDF_adaptive now shows the integration
of the logistic equation using adaptive time steps and
increasing integration order from 1 to 5.

* ODE: running BDF on StiffChemistry problem

The problem runs fine and is solved but there are oscillations
while the behavior of the solution is smooth. More investigation
is needed...

* BDF: fixing types and template parameters in batched calls

Bascially we need template parameters to be more versatile
and cannot assume that all rank1 views will have the exact
same underlying type, for instance layouts can be different.

* More fixes for GPUs only in tests this time.

* ODE: BDF adaptive, fix small bug

After adding rhs and update vectors to temp the subviews taken for
other variables need to be offset appropriately...

* Revert "More fixes for GPUs only in tests this time."

This reverts commit 2f70432.

* Revert "Revert "More fixes for GPUs only in tests this time.""

This reverts commit 836012b.

* ODE: BDF small change to temporarily avoid compile time issue

True fix involving a KOKKOS_VERSION check is upcoming after more
tests on GPU side...

* ODE: BDF fix for some printf statements that will go away soon...

* ODE: adding benchmark for BDF

The benchmark helps us monitor the performance of the BDF
implementaiton across multiple platforms as well as impact of
changes over time.

* ODE: improve benchmark interface...

* ODE: BDF changes to use RMS norm and change some default values

Small changes to compare more closely with reference implementation.
Some of these might be reverted eventually but that's fine for now.

* ODE: BDF convergence more stable and results look pretty good now!

Changing the Newton solver convergence criteria as well as changing
a few default input parameters leads to a more stable algorithms
which can now integrate the stiff Henderson autocatalytic example
well in 66 time steps instead of 200k for fixed order integration...

* ODE: BDF fix bug in initial time step calculation

The initial step routine was overwriting the initial right hand side
which led to obvious issues further down the road... now things should
work fine. Need to figure out if I can re-initialize the variables in
the perf test while excluding that time from each iteration.

* ODE: BDF removing bad print statement...

std::cout in device code

* ODE - BDF: improving perf test

Basically adding new untimed setup within the main loop of the
benchmark to reset the intial conditions, buffers and vectors
ahead of each iteration.

* Modifying unit-test to catch proper return type

* Applying clang-format

add rocm/5.6.1 and rocm/6.0.0, and openblas/0.3.23 as tpl

…2134)

* Sparse MKL: changing the location of the MKL_SAFE_CALL macro

Moving the macro outside of namespaces to ensure that it will be
interpreted correctly when called from any other location in the
library.

It does not make much sense to guard Impl code in the Experimental
namespace and in this case it cleans up a problem with namespace
disambiguation for the compiler...

* Sparse BsrSpMV: removing Experimental namespace from Impl namespace

* Applying clang-format

* Sparse SpMV: fixing more namespace issues!

…ia-caraway

cm_test_all_sandia: update caraway compilers

…kos#2140)

This change makes it easier for customer to leverage TPL support
which almost always requires offset=int, ordinal=int to be enabled
meaning that no TPL support is available with our default ETI...

Resolve compilation errors in nightly cuda/12.2 A100 build

…ssing_descriptor

Spmv bsr matrix fix missing matrix descriptor (rocsparse)

Temporary objects like "A()" get destructed immediately.
For the object to have scope lifetime, it needs a name like "A a();".
This was causing cusparse/rocsparse spmv to always execute on the default stream,
causing incorrect timing in the spmv perf test.

It actually is part of the public interface

…-namespacing

KokkosSparse_spmv_bsrmatrix_spec: fix Bsr_TC_Precision namespacing

)

* Spmv perf test improvements

- Add option to flush caches by filling a dummy buffer between
iterations
- Add option to call the non-reuse interface instead of handle/reuse
interface
- Fix modes T, H in nonsquare case (make x,y the correct length)

* Fix mode help text

One of the overload requires an unused template, removing that
extraneous template and simplify how that function is called in
a second overload.

Co-authored-by: brian-kelley <[email protected]>

module updates post TOSS upgrade

This is only hit when spmv is called with integer scalars,
which doesn't happen in our CI but does often in Tpetra.

…ia-solo

cm_test_all_sandia: solo updates

* SPMV tpl fixes, workaround

* Avoid possible integer conversion warnings

* Document cusparseSpMM algos that were tested

KokkosKernels Utils: cleaning the zero_vector interface

Now a declaration like CrsMatrix<Scalar, Ordinal, Device>
will by default use an ETI'd type combination (as int is the default
ETI'd offset)

CMakeLists.txt: Update develop to 4.3.99

…okkos#2139)

Some old code branches kept for compatibility with Kokkos Core
versions less than 4.2.00 are dropped after release 4.3.00.
The largest changes are the removal of support the Kokkos print
macro in favor of Kokkos::printf() and the removal of half support
from Kokkos Kernels since it is now in Kokkos Core.

* Correct flop count

* Addressing feedbacks from Luc

* Using 'zero()' instead of '0.'

…okkos#2157)

* KokkosBlas1_axpby.hpp: change debug macro guard for printInformation

- resolves test failures in Trilinos (MueLu) that rely on gold file diff
comparisons by removing extra output in debug builds

* fix compilation error

* Add user tolerance to Serial SVD
---------

Co-authored-by: whorne <[email protected]>
Co-authored-by: Carl Pearson <[email protected]>

* Add a simple Harwell-Boeing file reader

And a test that validates against the MM reader.

* Support for symmetrize

* This loop can be simplified, there's no diag duplication

* Improve IO test

(It should just be the default,
KokkosSpars::Impl::eti_spec_avail<..>::value)

Adding a ss.sync call fixes it but I have no idea why it
was needed here. All the other stringstream reads work fine.

spmv: add special path for rank-2 x/y, but where both have 1 column
and a TPL is available for rank-1 but not rank-2.

Also call "subhandle->set_exec_space" correctly in the TPLs to ensure
proper synchronization between setup, spmv and cleanup (in the case that
different exec instances are used in different calls)

- Update debug level to > 1 guarding `printInformation(...)` in
  KokkosBlas1_axpby.hpp to reduce noisy test output
- Loosen tolerance of lapack.svd test to avoid random failures that
  occur near prior tolerance level

Updates from feedback runnig Trilinos testing

CHANGELOG.md: 4.3.00 update to develop

…abled

Resolves redefintion of struct SVD compilation errors with both MKL and LAPACK are enabled
Reported by @maartenarnst in trilinos/Trilinos#12891

Co-authored-by: brian-kelley <[email protected]>

KokkosLapack_svd_tpl_spec_decl: defer to MKL spec when LAPACK also enabled

* Progress

* Attempt 1, fix multiplication order

* Converges in 1 step

* Various cleanups

* Be sure not to reduce performance of unblocked impl

Also add some comments.

* Remove test mangling

* Fixes for GPU

* Fix warning

* formatting

* Increase eps for floats

* This is no longer needed

…ENLAPACK_REL

Address issue kokkos#2175
Configuring with magma tpl enabled and cusparse disabled mistakenly triggers the cusparse tpl avail check to be true
Guard the KOKKOSSPARSE_SPMV_MV_TPL_SPEC_AVAIL_CUSPARSE macros when CUSPARSE is enabled to prevent this

Add guard for cusparse spmv_mv_tpl_spec_avail

…ero error

Address issue kokkos#2175

…x-divide-by-zero-in-trsv

Add early return if numRows == 0 in trsv to avoid integer divide-by-zero error

* magma: fix linker errors for builds without cusolver

* BatchedGemm test: workaround testing cublas+magma

- temporary workaround to skip magma test when cublas enabled to avoid issues like kokkos#2177

Add AutoTester2 CI Configs (Sans Power9 & ROCM w/ TPLS)

At2 ROCM+TPL fixes, remove volta70 too

- test against most recent kokkos release rather than develop branch, as
  done with AT CI, to avoid compatibility breakages

workflows/osx.yml: test against most recent kokkos tag

… symbol (kokkos#2183)

Stick to pattern of removing leading 'c' or 'z' in method name and relying on the template type

Co-authored-by: malphil <[email protected]>

- Get rid of SYCL_OVERRIDE setting
- Add MKL_PROVIDES_BLAS_LAPACK cmake variable and define so that
  code knows whether to use int, or MKL_INT
  - Trilinos builds might link with OneAPI for GPU but standard
    BLAS/LAPACK on CPU

* Fix docs build

* try docs fix

* make sphinx available at config time

Pretty much taking the new files from PR kokkos#2191 and re-creating
it in a clean PR on top of develop with small changes relevant
to our repository.

Cleaning up some workflows to tailor it for our needs

)

It needed to have size_type.

- avoid version range check issues for release tests

…ersion

docs.yml: change kokkos version to latest release

update changelog for 4.3.1

…arly (kokkos#2193)

This just improves the readability of the output from the tools as it now
has a symbolic matching the numeric phase. Previously we only had spgemm
in the label which is a bit confusing as it could be the whole spgemm time
i.e. both symbolic and numeric, additionally we had symbolic in the MKL
path but not in cusparse, rocsparse...

* Test_Sparse_spmv_bsr.hpp: add NaNs to tests

* handle NaN in spmv_beta_transpose when beta=0

* handle nan in SpmvMergeHierarchical when beta=0

* Test NaNs in Y, don't reuse modifed Y, catch NaNs in results test

* remove unused <iostream> include

* explicit casting of zero

* Test_sparse_spmv.hpp: remove unused nans parameter

* KokkosSparse_spmv.hpp: CUDA11 can't detect this function always returns

* Test_Sparse_spmv.hpp: remove unused variable

* Run unit tests in correct execution space

* Test_Sparse_spmv.hpp: remove unused type aliases

* Kokkos::nan() -> KokkosKernels::Impl::quiet_NaN()

(not deleted, just guarded with #if 0 and comments explaining)

It performs significantly worse than our native impl on 11.2, 11.8 and 12.0 on V100.
This is in the dot perf test with a warm-up call.

trilinos/Trilinos#12982 was a symptom of this.

* Restore cusparse spmv ALG2 path for imbalanced

With correct version cutoffs

* spmv: use separate rank-1 and rank-2 tpl subhandles

* Remove redundant single-column path in native spmv_mv

* Fix unused param warning

* c++17: add [[fallthrough]] attribute

* cm_test_all_sandia: -Wimplicit-fallthrough

* .github/mi210: Enable on PRs

* .github/mi210: Disable non-tpl build

* .github/bdw: Enable PR_BDW_GNU1020_OPENMP_SERIAL_LEFT_OPENBLAS_REL

* .github/h100: Enable PR_HOPPER90_CUDA1180_CUDA_LEFT_RIGHT_REL

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.6 to 2.3.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@99c5375...dc50aa9)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@a8a3f3a...6546280)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 2.5.1 to 4.3.2.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@0efb1d1...0c155c5)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@a4aa98b...f086349)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.25.3 to 3.25.6.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ceaec5c...9fdb3e4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

We state were patches will be made and how to report security vulnerabilities to the project.

* Kokkos Kernels: adding SHA for github actions

* Adding sha for docker images

* workflows: fix sha for label checker docker image

* workflows: fixing Docker files dependencies.